-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
bpo-31639: Change ThreadedHTTPServer to ThreadingHTTPServer class name #7195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LGTM, it make sense, but can probably only be merged before 3.7.0, as changing it after would mean breaking compatibility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if and only if the change is merged into 3.7 before 3.7 final.
The change doesn't break the backward compatibility because the renamed class has been introduced in Python 3.7 which is not released yet (beta versions have been released, but not the 3.7.0 final).
Thanks @maggyero for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
Sorry, @maggyero and @JulienPalard, I could not cleanly backport this to |
You forgot to update the entry in What's New. |
…ss name (pythonGH-7195). (cherry picked from commit 1cee216)
GH-7219 is a backport of this pull request to the 3.7 branch. |
@elprans Hey thanks for noticing, I'm fixing it and will backport both in the same PR in 3.7. |
@JulienPalard Thanks for the merge. |
Changes the class name
http.server.ThreadedHTTPServer
tohttp.server.ThreadingHTTPServer
introduced by @JulienPalard on 23 March 2018 for Python 3.7, in order to be consistent with the already existing classes:socketserver.ForkingTCPServer
;socketserver.ForkingUDPServer
;socketserver.ThreadingTCPServer
;socketserver.ThreadingUDPServer
.https://bugs.python.org/issue31639