Skip to content

bpo-31639: Change ThreadedHTTPServer to ThreadingHTTPServer class name #7195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2018

Conversation

geryogam
Copy link
Contributor

@geryogam geryogam commented May 29, 2018

Changes the class name http.server.ThreadedHTTPServer to http.server.ThreadingHTTPServer introduced by @JulienPalard on 23 March 2018 for Python 3.7, in order to be consistent with the already existing classes:

  • socketserver.ForkingTCPServer;
  • socketserver.ForkingUDPServer;
  • socketserver.ThreadingTCPServer;
  • socketserver.ThreadingUDPServer.

https://bugs.python.org/issue31639

@JulienPalard
Copy link
Member

LGTM, it make sense, but can probably only be merged before 3.7.0, as changing it after would mean breaking compatibility.

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if and only if the change is merged into 3.7 before 3.7 final.

The change doesn't break the backward compatibility because the renamed class has been introduced in Python 3.7 which is not released yet (beta versions have been released, but not the 3.7.0 final).

@JulienPalard JulienPalard merged commit 1cee216 into python:master May 29, 2018
@miss-islington
Copy link
Contributor

Thanks @maggyero for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @maggyero and @JulienPalard, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 1cee216cf383eade641aed22f4ec7d4cb565ecff 3.7

@elprans
Copy link
Contributor

elprans commented May 29, 2018

You forgot to update the entry in What's New.

JulienPalard pushed a commit to JulienPalard/cpython that referenced this pull request May 29, 2018
@bedevere-bot
Copy link

GH-7219 is a backport of this pull request to the 3.7 branch.

@JulienPalard
Copy link
Member

@elprans Hey thanks for noticing, I'm fixing it and will backport both in the same PR in 3.7.

JulienPalard added a commit that referenced this pull request May 30, 2018
…ss name (GH-7195) (GH-7219)

* [3.7] bpo-31639: Change ThreadedHTTPServer to ThreadingHTTPServer class name (GH-7195).
(cherry picked from commit 1cee216)

* Fix whatsnew entry about ThreadedHTTPServer. (GH-7220)
(cherry picked from commit a34e424)
@geryogam geryogam deleted the patch-1 branch May 30, 2018 21:37
@geryogam
Copy link
Contributor Author

@JulienPalard Thanks for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants