Skip to content

bpo-38101: Update devguide triaging keywords #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 23, 2020
Merged

bpo-38101: Update devguide triaging keywords #570

Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f000f3e
bpo-38101 Updated devguide triaging keywords.
idomic Feb 2, 2020
8dd4e49
Fixed comments
idomic Feb 8, 2020
17de196
Fixed reviewer comments
idomic Feb 13, 2020
c1e8e26
Fixed reviewer comments
idomic Feb 14, 2020
019d68c
Merge branch 'master' into bpo-38101-devguide_triaging_keywords
idomic Feb 18, 2020
f8a290c
Fixed reviewer comments
idomic Feb 22, 2020
1e18e28
Fixed reviewer comments
idomic Feb 22, 2020
9dc3ea6
Fixed reviewer comments
idomic Feb 22, 2020
c636089
Fixed reviewer comments
idomic Feb 22, 2020
0aa33c9
Fixed reviewer comments
idomic Feb 23, 2020
4451c03
fix PEP-3121 link
taleinat Feb 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions triaging.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,18 @@ Various informational flags about the issue. Multiple values are possible.
| easy | Fixing the issue should not take longer than a day for |
| | someone new to contributing to Python to solve. |
+---------------+------------------------------------------------------------+
| easy (C) | Fixing the issue should not take longer than a day for |
| | someone new contributing to Python, focused on C. |
+---------------+------------------------------------------------------------+
| security_issue| The issue would fit as, or is related as a security issue. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| security_issue| The issue would fit as, or is related as a security issue. |
| security_issue| This is a security issue or is related to one. |

| | The main difference from "security" is that this is a |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"security" is out of context here, so maybe write something "The main difference from the "secutiry" issue type is..."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added both changes, I think also since there is no security keyword in the bug tracker, the main difference is that is a definite problem right? While the security type above it is more for reporting a possible issue.

| | definite security problem that has to be dealt with. |
+---------------+------------------------------------------------------------+
| PEP 3121 | The issue fit as, or is related to the PEP 3121 module |
| | Which is the Extension Module Initialization and |
| | Finalization, For More information: |
| | https://www.python.org/dev/peps/pep-3121/ |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wording and capitalization here are a bit clumsy. My suggestion:

"The issue is related to `PEP 3121`_: Extension Module Initialization and Finalization."

(The above assumes adding the link for PEP 3121 below it.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the requested changes; please review again

+---------------+------------------------------------------------------------+
| newcomer | Issue suitable for newcomer/first time contributors. |
| friendly | Not suitable for experienced contributors. Typically it is |
| | straightforward, well-defined, low-risk, and optionally |
Expand Down