Fix stubtest of pyserial #9722
Merged
Fix stubtest of pyserial #9722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
@AlexWaygood I fixed all post-stubtest-activation ignores. Tested locally on Windows and Linux. Thanks for the first PR and for tagging me (and hope you enjoyed/still enjoying your holidays) |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
@hamdanal thanks! I get back tomorrow, will take a look then :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stubtest was enabled for the pyserial stubs recently in #9692 and it surfaced some errors especially on Windows that were allow-listed temporarily to get the CI green. This is a fix for these errors.