Convert relative to absolute paths in link resolving #3
Conversation
| if os.path.isabs(dotnet_tmp_path): | ||
| dotnet_path = dotnet_tmp_path | ||
| else: | ||
| dotnet_path = os.path.abspath(os.path.join(os.path.dirname(dotnet_path), dotnet_tmp_path)) |
There was a problem hiding this comment.
Wouldn't simply doing os.path.abspath(os.readlink(dotnet_path)) be enough?
There was a problem hiding this comment.
Thought about that. I'll try it later. Wasn't sure where abspath will base on. So I wanted to be sure
There was a problem hiding this comment.
So I tried that now and it didn't work. Because:
os.path.abspath(path)
Return a normalized absolutized version of the pathname path. On most platforms, this is equivalent to calling the function normpath() as follows: normpath(join(os.getcwd(), path))
So what abspath does is to take the current working directy (where you started the script) and apply normpath(join(os.getcwd(), path)) .
That's why you would need all the fancy if else stuff. So in my case:
dotnet_root was /usr/bin/dotnet which was a symlink to ../share/dotnet/dotnet that was being taken by the abspath and concatenated onto my user directory /home/bneumann/pythonnet/clr-loader/share/dotnet/dotnet
Was just checking put the code under linux to see how it works. Didn't find dotnet_root under '../share/dotnet' so I added a little converter.