Skip to content

Switch deprecated ubuntu-18.04 runner to ubuntu-latest #1334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 17, 2023
Merged

Switch deprecated ubuntu-18.04 runner to ubuntu-latest #1334

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7ca0c3a
Switch deprecated ubuntu-18.04 runner to self-hosted 2xlarge
huydhn Mar 6, 2023
dd544e4
Leave build-nvidia-docker for now
huydhn Mar 6, 2023
bdc5745
Apply suggestions from code review
huydhn Mar 7, 2023
5fd0bef
Use ephemeral runners
huydhn Mar 7, 2023
835d35e
Use ubuntu-latest
huydhn Mar 7, 2023
990c6d4
Apply suggestions from code review
huydhn Mar 17, 2023
6fb2185
Switch from latest to 22.04 to pin the version
huydhn Mar 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-conda-images.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ env:

jobs:
build-docker:
runs-on: linux.2xlarge
runs-on: ubuntu-latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change is needed?

Copy link
Contributor Author

@huydhn huydhn Mar 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was probably an oversight in the past. I couldn't figure out why we use non-ephemeral linux.2xlarge for conda build while use ubuntu-VERSION for wheel. It makes sense to have both running in the same type of non-ephemeral runner?

strategy:
matrix:
cuda_version: ["11.6", "11.7", "11.8", "cpu"]
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/build-libtorch-images.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ env:

jobs:
build-docker-cuda:
runs-on: ubuntu-18.04
runs-on: ubuntu-latest
strategy:
matrix:
cuda_version: ["11.8", "11.7", "11.6"]
Expand All @@ -44,7 +44,7 @@ jobs:
run: |
libtorch/build_docker.sh
build-docker-rocm:
runs-on: ubuntu-18.04
runs-on: ubuntu-latest
strategy:
matrix:
rocm_version: ["5.3", "5.4.2"]
Expand All @@ -63,7 +63,7 @@ jobs:
run: |
libtorch/build_docker.sh
build-docker-cpu:
runs-on: ubuntu-18.04
runs-on: ubuntu-latest
steps:
- name: Checkout PyTorch
uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-magma-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
push-windows-magma:
if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }}
environment: magma
runs-on: ubuntu-18.04
runs-on: ubuntu-latest
needs: build-windows-magma
steps:
- name: Download all artifacts
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/build-manywheel-images.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ env:

jobs:
build-docker-cuda:
runs-on: ubuntu-18.04
runs-on: ubuntu-latest
strategy:
matrix:
cuda_version: ["11.8", "11.7", "11.6"]
Expand All @@ -46,7 +46,7 @@ jobs:
run: |
manywheel/build_docker.sh
build-docker-rocm:
runs-on: ubuntu-18.04
runs-on: ubuntu-latest
strategy:
matrix:
rocm_version: ["5.3", "5.4.2"]
Expand All @@ -65,7 +65,7 @@ jobs:
run: |
manywheel/build_docker.sh
build-docker-cpu:
runs-on: ubuntu-18.04
runs-on: ubuntu-latest
steps:
- name: Checkout PyTorch
uses: actions/checkout@v3
Expand All @@ -78,7 +78,7 @@ jobs:
run: |
manywheel/build_docker.sh
build-docker-cpu-cxx11-abi:
runs-on: ubuntu-18.04
runs-on: ubuntu-latest
env:
GPU_ARCH_TYPE: cpu-cxx11-abi
steps:
Expand Down