WIN smoke test support for nightly package #456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjc123
reviewed
Jun 13, 2020
| ) | ||
|
|
||
| if "%DESIRED_CUDA%" == "cpu" ( | ||
| call conda list torch | grep cuda || exit /b 0 |
There was a problem hiding this comment.
nit: Consider replacing grep with findstr.
There was a problem hiding this comment.
Why do you search for cuda here? Could you please explain?
There was a problem hiding this comment.
nit: Consider replacing
grepwithfindstr.
ok
There was a problem hiding this comment.
Why do you search for cuda here? Could you please explain?
If 'cuda' is found in torch package name, then it's build for cuda, not for cpu, print the error info and exit /b 1, else exit /b 0
corresponding linux code is
Line 172 in 39d5dd4
| echo "The installed package is built for CUDA, the full package is" | ||
| call conda list torch | ||
| ) else ( | ||
| call conda list torch | grep cuda%CUDA_VERSION% && exit /b 0 |
guyang3532
force-pushed
the
add_win_smoke_test
branch
from
e6e1a86 to
eff4857
Compare
peterjc123
approved these changes
Jun 13, 2020
guyang3532
force-pushed
the
add_win_smoke_test
branch
from
eff4857 to
601a85d
Compare
|
@soumith @seemethere Could you please take a look? |
seemethere
approved these changes
Jun 16, 2020
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jun 16, 2020
Summary: Related pr: pytorch/builder#456 test at:#39943 Pull Request resolved: #39941 Differential Revision: D22068004 Pulled By: ezyang fbshipit-source-id: 5244f64d842b3a8bf0af720dffb4b1a0370cc178
xwang233
pushed a commit
to xwang233/pytorch
that referenced
this pull request
Jun 20, 2020
Summary: Related pr: pytorch/builder#456 test at:pytorch#39943 Pull Request resolved: pytorch#39941 Differential Revision: D22068004 Pulled By: ezyang fbshipit-source-id: 5244f64d842b3a8bf0af720dffb4b1a0370cc178
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related pr: pytorch/pytorch#39941
test at: pytorch/pytorch#39943