Split neutron backend test based on executor dependency #11934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11934
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 Cancelled Jobs, 1 Unrelated FailureAs of commit 9df4df7 with merge base f9a3ca8 ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D77248751 |
|
@pytorchbot label "release notes: none" |
pytorch-bot
bot
added
the
release notes: none
|
This pull request was exported from Phabricator. Differential Revision: D77248751 |
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Jun 26, 2025
Summary: Pull Request resolved: pytorch#11934 The current test_neutron_backend has a hard requirement on tflite due to the Executor comparing the output. Not all systems have tflite, but we would like to have a sanity check on the backend still. To achieve this, this PR splits the existing test into two files test_neutron_backend contains the tests that do not use any Executor logic (ie, no end to end comparison of outputs) test_neutron_backend_executor contains the rest of the tests. Differential Revision: D77248751
JakeStevens
force-pushed
the
export-D77248751
branch
from
d245519 to
248c5e7
Compare
|
In general looks good to me. How do you plan to execute tests only in particular files? I believe pytest will fail to run anything if there's at least single file with problematic import. Only working solutions how to execute this are imho 1) single file's tests execution 2) predefined list of "files with supported tests". Please rebase to main to include nxp-unittest workflow. |
skywall
approved these changes
Jun 30, 2025
This is an issue specific to our internal workflow, which does not use the OSS flow but uses BUCK entirely. So, you just only include the files you want in your BUCK target, very easy (basically a special form of your #2 suggestion). Will rebase |
|
This pull request was exported from Phabricator. Differential Revision: D77248751 |
JakeStevens
force-pushed
the
export-D77248751
branch
from
248c5e7 to
5d36490
Compare
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Jun 30, 2025
Summary: Pull Request resolved: pytorch#11934 The current test_neutron_backend has a hard requirement on tflite due to the Executor comparing the output. Not all systems have tflite, but we would like to have a sanity check on the backend still. To achieve this, this PR splits the existing test into two files test_neutron_backend contains the tests that do not use any Executor logic (ie, no end to end comparison of outputs) test_neutron_backend_executor contains the rest of the tests. Differential Revision: D77248751
|
This pull request was exported from Phabricator. Differential Revision: D77248751 |
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Jul 1, 2025
Summary: Pull Request resolved: pytorch#11934 The current test_neutron_backend has a hard requirement on tflite due to the Executor comparing the output. Not all systems have tflite, but we would like to have a sanity check on the backend still. To achieve this, this PR splits the existing test into two files test_neutron_backend contains the tests that do not use any Executor logic (ie, no end to end comparison of outputs) test_neutron_backend_executor contains the rest of the tests. Differential Revision: D77248751
JakeStevens
force-pushed
the
export-D77248751
branch
from
5d36490 to
95d08e6
Compare
JakeStevens
pushed a commit
to JakeStevens/executorch
that referenced
this pull request
Jul 3, 2025
Summary: Pull Request resolved: pytorch#11934 The current test_neutron_backend has a hard requirement on tflite due to the Executor comparing the output. Not all systems have tflite, but we would like to have a sanity check on the backend still. To achieve this, this PR splits the existing test into two files test_neutron_backend contains the tests that do not use any Executor logic (ie, no end to end comparison of outputs) test_neutron_backend_executor contains the rest of the tests. Differential Revision: D77248751
|
This pull request was exported from Phabricator. Differential Revision: D77248751 |
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Jul 3, 2025
Summary: Pull Request resolved: pytorch#11934 The current test_neutron_backend has a hard requirement on tflite due to the Executor comparing the output. Not all systems have tflite, but we would like to have a sanity check on the backend still. To achieve this, this PR splits the existing test into two files test_neutron_backend contains the tests that do not use any Executor logic (ie, no end to end comparison of outputs) test_neutron_backend_executor contains the rest of the tests. Differential Revision: D77248751
JakeStevens
force-pushed
the
export-D77248751
branch
from
95d08e6 to
5815e77
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77248751 |
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Jul 7, 2025
Summary: Pull Request resolved: pytorch#11934 The current test_neutron_backend has a hard requirement on tflite due to the Executor comparing the output. Not all systems have tflite, but we would like to have a sanity check on the backend still. To achieve this, this PR splits the existing test into two files test_neutron_backend contains the tests that do not use any Executor logic (ie, no end to end comparison of outputs) test_neutron_backend_executor contains the rest of the tests. Differential Revision: D77248751
JakeStevens
force-pushed
the
export-D77248751
branch
from
5815e77 to
f01d69f
Compare
JakeStevens
pushed a commit
to JakeStevens/executorch
that referenced
this pull request
Jul 7, 2025
Summary: Pull Request resolved: pytorch#11934 The current test_neutron_backend has a hard requirement on tflite due to the Executor comparing the output. Not all systems have tflite, but we would like to have a sanity check on the backend still. To achieve this, this PR splits the existing test into two files test_neutron_backend contains the tests that do not use any Executor logic (ie, no end to end comparison of outputs) test_neutron_backend_executor contains the rest of the tests. Differential Revision: D77248751
|
LGTM, |
robert-kalmar
approved these changes
Jul 8, 2025
Summary: Pull Request resolved: pytorch#11934 The current test_neutron_backend has a hard requirement on tflite due to the Executor comparing the output. Not all systems have tflite, but we would like to have a sanity check on the backend still. To achieve this, this PR splits the existing test into two files test_neutron_backend contains the tests that do not use any Executor logic (ie, no end to end comparison of outputs) test_neutron_backend_executor contains the rest of the tests. Reviewed By: digantdesai Differential Revision: D77248751
|
This pull request was exported from Phabricator. Differential Revision: D77248751 |
JakeStevens
force-pushed
the
export-D77248751
branch
from
f01d69f to
9df4df7
Compare
digantdesai
approved these changes
Jul 8, 2025
Tanish2101
pushed a commit
to Tanish2101/executorch
that referenced
this pull request
Jul 9, 2025
Summary: The current test_neutron_backend has a hard requirement on tflite due to the Executor comparing the output. Not all systems have tflite, but we would like to have a sanity check on the backend still. To achieve this, this PR splits the existing test into two files test_neutron_backend contains the tests that do not use any Executor logic (ie, no end to end comparison of outputs) test_neutron_backend_executor contains the rest of the tests. Differential Revision: D77248751
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The current test_neutron_backend has a hard requirement on tflite due to the Executor comparing the output.
Not all systems have tflite, but we would like to have a sanity check on the backend still.
To achieve this, this PR splits the existing test into two files
test_neutron_backend contains the tests that do not use any Executor logic (ie, no end to end comparison of outputs)
test_neutron_backend_executor contains the rest of the tests.
Differential Revision: D77248751