Skip to content

[Backend Tester] Add CoreML tester implementation #11959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025

Conversation

GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Jun 25, 2025

Add a tester implementation for Core ML. This uses the common backend tester framework to allow Core ML to plug into the test harness using pybindings.

@GregoryComer GregoryComer requested a review from shoumikhin as a code owner June 25, 2025 06:36
@GregoryComer
Copy link
Member Author

GregoryComer commented Jun 25, 2025

@GregoryComer GregoryComer requested a review from cccclai as a code owner June 25, 2025 06:36
Copy link

pytorch-bot bot commented Jun 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11959

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 23 Pending

As of commit d5041c9 with merge base 264ac90 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 25, 2025
@GregoryComer GregoryComer changed the title Add CoreML tester implementation [Backend Tester] Add CoreML tester implementation Jun 25, 2025
@GregoryComer GregoryComer requested a review from digantdesai June 25, 2025 20:42
Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean. No test for a tester? Also I gues the tester refactoring should be in between the FACTO and CoreML diffs?

Base automatically changed from gh/GregoryComer/64/head to main July 8, 2025 17:04
@GregoryComer GregoryComer requested a review from mcr229 as a code owner July 8, 2025 17:04
@GregoryComer GregoryComer force-pushed the gh/GregoryComer/69/head branch from a931676 to 4408e9a Compare July 8, 2025 17:23
@GregoryComer GregoryComer added the release notes: none Do not include this in the release notes label Jul 8, 2025
@GregoryComer GregoryComer force-pushed the gh/GregoryComer/69/head branch from 4408e9a to d5041c9 Compare July 8, 2025 17:42
@GregoryComer GregoryComer merged commit f9a3ca8 into main Jul 8, 2025
100 checks passed
@GregoryComer GregoryComer deleted the gh/GregoryComer/69/head branch July 8, 2025 18:01
Tanish2101 pushed a commit to Tanish2101/executorch that referenced this pull request Jul 9, 2025
Add a tester implementation for Core ML. This uses the common backend
tester framework to allow Core ML to plug into the test harness using
pybindings.
example_inputs: Tuple[torch.Tensor],
dynamic_shapes: Optional[Tuple[Any]] = None,
):
# Specialize for XNNPACK
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants