Skip to content

Update to ROCm5.3 for nightly #1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jithunnair-amd
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Dec 7, 2022

👷 Deploy Preview for pytorch-dot-org-preview processing.

Name Link
🔨 Latest commit 32fbca6
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-dot-org-preview/deploys/6390e50cc99fe4000857cbd8

@jithunnair-amd
Copy link
Contributor Author

jithunnair-amd commented Dec 7, 2022

@kit1980 @atalman @malfet All ROCm CI jobs passed. Netlify preview looks good. Can we please merge this?

@malfet
Copy link
Contributor

malfet commented Dec 7, 2022

@jithunnair-amd I though Andrey revamped the system recently to use release matrix and do automated updates (as in #1214 ) so those manual one should no longer be neccesary

@atalman
Copy link
Contributor

atalman commented Dec 7, 2022

@jithunnair-amd No need to use manual update now anymore. Will check now why rocm 5.3 was not picked up in #1214
Also before merging we would need to make sure signal is green

@jithunnair-amd
Copy link
Contributor Author

@jithunnair-amd I though Andrey revamped the system recently to use release matrix and do automated updates (as in #1214 ) so those manual one should no longer be neccesary

That's just what I wanted to hear :)

@atalman Okay, feel free to close this PR if you'll be making the ROCm version upgrade in #1214

@atalman
Copy link
Contributor

atalman commented Dec 7, 2022

@jithunnair-amd Sounds good. Actually small correction to previous statement, you still need to advance rcom version here, like this: #1231
However let me know I can automatically pick latest Rocm available for nightly, now we have 5.2 and 5.3

Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, than those changes seems correct to me, aren't they?

@atalman
Copy link
Contributor

atalman commented Dec 7, 2022

Hmm, than those changes seems correct to me, aren't they?

Yes changes are correct, the way the generation was refactored is to still allow manual updates. However I think we should

  1. Prefer automatic updates
  2. Update on green signal

I will put up a PR to update acc_arch_ver_map automatically by taking latest versions of rocm and cuda available in release matrix.

@atalman
Copy link
Contributor

atalman commented Dec 8, 2022

closing this, not required anymore

@atalman atalman closed this Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants