-
Notifications
You must be signed in to change notification settings - Fork 306
Update to ROCm5.3 for nightly #1228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to ROCm5.3 for nightly #1228
Conversation
👷 Deploy Preview for pytorch-dot-org-preview processing.
|
@jithunnair-amd I though Andrey revamped the system recently to use release matrix and do automated updates (as in #1214 ) so those manual one should no longer be neccesary |
@jithunnair-amd No need to use manual update now anymore. Will check now why rocm 5.3 was not picked up in #1214 |
That's just what I wanted to hear :) @atalman Okay, feel free to close this PR if you'll be making the ROCm version upgrade in #1214 |
@jithunnair-amd Sounds good. Actually small correction to previous statement, you still need to advance rcom version here, like this: #1231 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, than those changes seems correct to me, aren't they?
Yes changes are correct, the way the generation was refactored is to still allow manual updates. However I think we should
I will put up a PR to update acc_arch_ver_map automatically by taking latest versions of rocm and cuda available in release matrix. |
closing this, not required anymore |
No description provided.