Skip to content

Add architecture extraction logic to getting started page generation #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 8, 2022
Merged

Add architecture extraction logic to getting started page generation #1232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0280ce
Add architecture ectraction logic
atalman Dec 7, 2022
21d0a4f
Fix wording
atalman Dec 7, 2022
f587f10
Address feedback
atalman Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/update-quick-start-module.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,5 +107,5 @@ jobs:
commit-message: Modify published_versions.json file
title: '[Getting Started Page] Modify published_versions.json file'
body: >
This PR is auto-generated Gettins Started page update
This PR is auto-generated. It updates Getting Started page
labels: automated pr
33 changes: 28 additions & 5 deletions scripts/gen_quick_start_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,8 @@ class OperatingSystem(Enum):
ENABLE = "enable"
DISABLE = "disable"

# Mapping json to release matrix is here for now
# TBD drive the mapping via:
# 1. Scanning release matrix and picking 2 latest cuda versions and 1 latest rocm
# 2. Possibility to override the scanning algorithm with arguments passed from workflow
acc_arch_ver_map = {
# Mapping json to release matrix default values
acc_arch_ver_default = {
"nightly": {
"accnone": ("cpu", ""),
"cuda.x": ("cuda", "11.6"),
Expand All @@ -49,6 +46,11 @@ class OperatingSystem(Enum):
}
}

# Initialize arch version to default values
# these default values will be overwritten by
# extracted values from the release marix
acc_arch_ver_map = acc_arch_ver_default

LIBTORCH_DWNL_INSTR = {
PRE_CXX11_ABI: "Download here (Pre-cxx11 ABI):",
CXX11_ABI: "Download here (cxx11 ABI):",
Expand Down Expand Up @@ -163,6 +165,26 @@ def gen_install_matrix(versions) -> Dict[str, str]:
result[key] = "<br />".join(lines)
return result

# This method is used for extracting two latest verisons of cuda and
# last verion of rocm. It will modify the acc_arch_ver_map object used
# to update getting started page.
def extract_arch_ver_map(release_matrix):
def gen_ver_list(chan, gpu_arch_type):
return {
x["desired_cuda"]: x["gpu_arch_version"]
for x in release_matrix[chan]["linux"]
if x["gpu_arch_type"] == gpu_arch_type
}

for chan in ("nightly", "release"):
cuda_ver_list = gen_ver_list(chan, "cuda")
rocm_ver_list = gen_ver_list(chan, "rocm")
cuda_list = sorted(cuda_ver_list.values())[-2:]
acc_arch_ver_map[chan]["rocm5.x"] = ("rocm", max(rocm_ver_list.values()))
for cuda_ver, label in zip(cuda_list, ["cuda.x", "cuda.y"]):
acc_arch_ver_map[chan][label] = ("cuda", cuda_ver)


def main():
parser = argparse.ArgumentParser()
parser.add_argument('--autogenerate', dest='autogenerate', action='store_true')
Expand All @@ -178,6 +200,7 @@ def main():
for osys in OperatingSystem:
release_matrix[val][osys.value] = read_matrix_for_os(osys, val)

extract_arch_ver_map(release_matrix)
for val in ("nightly", "release"):
update_versions(versions, release_matrix[val], val)

Expand Down