make duplicate def() calls an error in the dispatcher #48098
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Nov 17, 2020
ezyang
approved these changes
Nov 17, 2020
Differential Revision: [D25022849](https://our.internmc.facebook.com/intern/diff/D25022849) [ghstack-poisoned]
Differential Revision: [D25022849](https://our.internmc.facebook.com/intern/diff/D25022849) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 22a5df8 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 62 times. |
Differential Revision: [D25022849](https://our.internmc.facebook.com/intern/diff/D25022849) [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Nov 18, 2020
Pull Request resolved: #48098 Differential Revision: [D25056089](https://our.internmc.facebook.com/intern/diff/D25056089/) ghstack-source-id: 117007279
Differential Revision: [D25022849](https://our.internmc.facebook.com/intern/diff/D25022849) [ghstack-poisoned]
Differential Revision: [D25022849](https://our.internmc.facebook.com/intern/diff/D25022849) [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Nov 18, 2020
Pull Request resolved: #48098 Differential Revision: [D25056089](https://our.internmc.facebook.com/intern/diff/D25056089/) ghstack-source-id: 117033201
ezyang
approved these changes
Nov 18, 2020
Differential Revision: [D25022849](https://our.internmc.facebook.com/intern/diff/D25022849) [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Nov 18, 2020
Pull Request resolved: #48098 Differential Revision: [D25056089](https://our.internmc.facebook.com/intern/diff/D25056089/) ghstack-source-id: 117047149
Differential Revision: [D25022849](https://our.internmc.facebook.com/intern/diff/D25022849) [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Nov 19, 2020
Pull Request resolved: #48098 Differential Revision: [D25056089](https://our.internmc.facebook.com/intern/diff/D25056089/) ghstack-source-id: 117118952
Differential Revision: [D25022849](https://our.internmc.facebook.com/intern/diff/D25022849) [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Nov 30, 2020
Pull Request resolved: #48098 Differential Revision: [D25056089](https://our.internmc.facebook.com/intern/diff/D25056089/) ghstack-source-id: 117441832
Differential Revision: [D25022849](https://our.internmc.facebook.com/intern/diff/D25022849) [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Nov 30, 2020
Pull Request resolved: #48098 Differential Revision: [D25056089](https://our.internmc.facebook.com/intern/diff/D25056089/) ghstack-source-id: 117457137
Differential Revision: [D25022849](https://our.internmc.facebook.com/intern/diff/D25022849) [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Dec 1, 2020
Pull Request resolved: #48098 Differential Revision: [D25056089](https://our.internmc.facebook.com/intern/diff/D25056089/) ghstack-source-id: 117540920
Differential Revision: [D25022849](https://our.internmc.facebook.com/intern/diff/D25022849) [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Dec 1, 2020
Pull Request resolved: #48098 Differential Revision: [D25056089](https://our.internmc.facebook.com/intern/diff/D25056089/) ghstack-source-id: 117545364
Differential Revision: [D25022849](https://our.internmc.facebook.com/intern/diff/D25022849) [ghstack-poisoned]
Differential Revision: [D25022849](https://our.internmc.facebook.com/intern/diff/D25022849) [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Dec 1, 2020
Pull Request resolved: #48098 Differential Revision: [D25056089](https://our.internmc.facebook.com/intern/diff/D25056089/) ghstack-source-id: 117574791
Differential Revision: [D25022849](https://our.internmc.facebook.com/intern/diff/D25022849) [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Dec 2, 2020
Pull Request resolved: #48098 Differential Revision: [D25056089](https://our.internmc.facebook.com/intern/diff/D25056089/) ghstack-source-id: 117623328
Differential Revision: [D25022849](https://our.internmc.facebook.com/intern/diff/D25022849) [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Dec 2, 2020
Pull Request resolved: #48098 Differential Revision: [D25056089](https://our.internmc.facebook.com/intern/diff/D25056089/) ghstack-source-id: 117653425
Differential Revision: [D25022849](https://our.internmc.facebook.com/intern/diff/D25022849) [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Dec 4, 2020
Pull Request resolved: #48098 Differential Revision: [D25056089](https://our.internmc.facebook.com/intern/diff/D25056089/) ghstack-source-id: 117901423
Differential Revision: [D25022849](https://our.internmc.facebook.com/intern/diff/D25022849) [ghstack-poisoned]
Differential Revision: [D25022849](https://our.internmc.facebook.com/intern/diff/D25022849) [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Dec 7, 2020
Pull Request resolved: #48098 Differential Revision: [D25056089](https://our.internmc.facebook.com/intern/diff/D25056089/) ghstack-source-id: 117986942
Differential Revision: [D25022849](https://our.internmc.facebook.com/intern/diff/D25022849) [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Dec 9, 2020
Pull Request resolved: #48098 Differential Revision: [D25056089](https://our.internmc.facebook.com/intern/diff/D25056089/) ghstack-source-id: 118197074
bdhirsh
added a commit
that referenced
this pull request
Dec 11, 2020
fbcode shows some `test_dispatch.py` tests failing after my previous PR here: #48098 https://www.internalfb.com/tasks/?t=81313176 I fixed some failing tests to expect a duplicate def error, and updated the error strings expected in the tests by running `EXPECTTEST_ACCEPT=1 python test/test_dispatch.py`, as indicated in `torch/testing/_internal/expecttest.py`. Should these tests run in OSS? It looks like they currently don't (it looks like they also didn't run in my phabricator diff). Differential Revision: [D25505170](https://our.internmc.facebook.com/intern/diff/D25505170) [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Dec 14, 2020
fbcode shows some `test_dispatch.py` tests failing after my previous PR here: #48098 https://www.internalfb.com/tasks/?t=81313176 I fixed some failing tests to expect a duplicate def error, and updated the error strings expected in the tests by running `EXPECTTEST_ACCEPT=1 python test/test_dispatch.py`, as indicated in `torch/testing/_internal/expecttest.py`. Should these tests run in OSS? It looks like they currently don't (it looks like they also didn't run in my phabricator diff). Differential Revision: [D25505170](https://our.internmc.facebook.com/intern/diff/D25505170) [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Dec 14, 2020
fbcode shows some `test_dispatch.py` tests failing after my previous PR here: #48098 https://www.internalfb.com/tasks/?t=81313176 I fixed some failing tests to expect a duplicate def error, and updated the error strings expected in the tests by running `EXPECTTEST_ACCEPT=1 python test/test_dispatch.py`, as indicated in `torch/testing/_internal/expecttest.py`. Should these tests run in OSS? It looks like they currently don't (it looks like they also didn't run in my phabricator diff). Differential Revision: [D25505170](https://our.internmc.facebook.com/intern/diff/D25505170) [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D25022849