-
Notifications
You must be signed in to change notification settings - Fork 814
Add a class method in Model Bundler to facilitate model creation with user-defined configuration and checkpoint #1442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4b301cd
add from_config bundler method
parmeet 04514c2
Merge branch 'main' of github.com:pytorch/text into bundler_from_config
parmeet f303d86
make amendments
parmeet 0e41e4d
Merge branch 'main' of github.com:pytorch/text into bundler_from_config
parmeet 9a0b571
fix tests
parmeet 992304d
fix doc
parmeet 7cfdffc
update checkpoint logic
parmeet 03b8584
Merge branch 'main' of github.com:pytorch/text into bundler_from_config
parmeet 8b4048a
solidifying behaviour around checkpoint and head
parmeet a60eaee
fixing minor docstring
parmeet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mthrok I have updated the logic how to handle the case when checkpoint contains the head parameters or not.
Case1: Does not contains head parameters: In this case, we would update the state with supplied head state dict. This would mean that we are keeping intact the head module whatever is provided by the user. This is inline with what we discussed here #1424 (comment)
Case2: Does contain head parameters: In this case we would use the checkpoint as such.
Note that in both the cases, now we have made
strict=True
to ensure all key matches. Let me know if this sounds reasonable to contain various edge cases?