pytorch/torchcodec - 3.12 fixes #744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D77327183 |
Summary: Noticed the abandoned codemod (D77291340) and figured I would fix the test. importlib.resources.path has always returned a context manger, but I guess it was pathlike before so nobody bothered using it. So going back to the introduction of importlib.resources in 3.7 its been a context manager so this is safe. Differential Revision: D77327183
|
This pull request was exported from Phabricator. Differential Revision: D77327183 |
Dan-Flores
pushed a commit
to Dan-Flores/torchcodec
that referenced
this pull request
Jul 17, 2025
Differential Revision: D77327183 Pull Request resolved: pytorch#744
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Noticed the abandoned codemod and figured I would fix the test.
importlib.resources.path has always returned a context manger, but I guess it was pathlike before so nobody bothered using it. So going back to the introduction of importlib.resources in 3.7 its been a context manager so this is safe.
Differential Revision: D77327183