Do not link to pthread when targeting Android #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How are you compiling it? Our CI does compile the library. |
|
Yeah just noticed the android workflow. I think the reason has to do with BUILD_QJS_LIBC, because this I set this ON. There's not much here # QuickJS
set(BUILD_QJS_LIBC ON CACHE BOOL "" FORCE)
add_subdirectory(vendor/quickjs EXCLUDE_FROM_ALL) |
|
I see. Can you please set that option (with |
saghul
reviewed
Mar 19, 2024
CMakeLists.txt
Outdated
| @@ -155,7 +155,11 @@ endif() | |||
| list(APPEND qjs_defines _GNU_SOURCE) | |||
| list(APPEND qjs_libs qjs ${CMAKE_DL_LIBS}) | |||
| if(NOT MSVC) | |||
| list(APPEND qjs_libs m pthread) | |||
| if (NOT ANDROID) | |||
There was a problem hiding this comment.
While this works, I think using CMAKE_THREAD_LIBS_INIT feels more future proof: https://cmake.org/cmake/help/latest/module/FindThreads.html
I had issues compiling this for Android, and as it turns out, pthread functionality is part of Bionic itself and linking is not required.
aabajyan
force-pushed
the
android-threads
branch
from
cb0f121 to
119fd56
Compare
saghul
approved these changes
Mar 19, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had issues compiling this for Android, and as it turns out, pthread functionality is part of libc itself and linking is not required. If there's any issues let me know!
The error I got: