Skip to content

fix memory leaks in run-test262 #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

chqrlie
Copy link
Collaborator

@chqrlie chqrlie commented Apr 4, 2024

No description provided.

@chqrlie chqrlie merged commit 02c06d0 into quickjs-ng:master Apr 5, 2024
@chqrlie chqrlie deleted the fix-test262-leaks branch April 5, 2024 10:06
@chqrlie
Copy link
Collaborator Author

chqrlie commented Apr 5, 2024

@saghul: The leaks are gone, but there is a persistent error with the Atomics:

test262/test/built-ins/Atomics/notify/notify-all-on-loc.js:13: strict mode: unexpected error: Test262Error:
The value of reports[NUMAGENT + 1] is "W timeout after Atomics.notify"
Expected SameValue("W timeout before Atomics.notify", "W timeout after Atomics.notify") to be true

@saghul
Copy link
Contributor

saghul commented Apr 5, 2024

Is that new? I didn't see it when I turned them on.

@chqrlie
Copy link
Collaborator Author

chqrlie commented Apr 5, 2024

The valgrind test is only performed after the merge. You can see the failure(s) in the Actions tab.

@saghul
Copy link
Contributor

saghul commented Apr 5, 2024

Ah the valgring one! Sure thing, I'll take a look!

@saghul
Copy link
Contributor

saghul commented Apr 6, 2024

Looking at all recent runs (https://github.com/quickjs-ng/quickjs/actions/workflows/valgrind.yml) looks like it succeeded at least twice and failed also twice. My first suspicion here is timing, since valgrind is slooooow...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants