Skip to content

Fix FinalizationRegistry with primitive held value #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2024
Merged

Fix FinalizationRegistry with primitive held value #496

merged 1 commit into from
Sep 4, 2024

Conversation

bnoordhuis
Copy link
Contributor

Apparently test262 does not test FinalizationRegistry#register() with held values that are not objects.

Fixes: #494

@bnoordhuis
Fix FinalizationRegistry with primitive held value
b1ba3ff 
Apparently test262 does not test FinalizationRegistry#register() with
held values that are not objects.

Fixes: quickjs-ng#494
saghul
saghul approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Ben!

@bnoordhuis bnoordhuis merged commit 8c58e01 into quickjs-ng:master Sep 4, 2024
50 checks passed
@bnoordhuis bnoordhuis deleted the fix494 branch September 4, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saghul saghul saghul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FinalizationRegistry / gc woes
2 participants
@bnoordhuis @saghul