Skip to content

enable windows binary module import #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

malyjacob
Copy link

enable wondows binary module importing, which allow no modification of the origin scripts using binary module importing in project.

try run on windows:

$ mkdir build
$ cd build
$ cmake .. -DBUILD_EXAMPLES=ON
$ cmake --build . --config Release

And after the above, try copy the target file qjs.exe, fib.dll, point.dll to dir examples and run the following:

$ .\qjs.exe .\test_fib.js
$ .\qjs.exe .\test_point.js

And the output is all right.

@saghul
Copy link
Contributor

saghul commented Sep 5, 2024

Ops #490 was in progress.

add_library(fib MODULE examples/fib.c)
set_target_properties(fib PROPERTIES
PREFIX ""
C_VISIBILITY_PRESET default
)
target_include_directories(fib PRIVATE .)
target_link_libraries(fib PRIVATE qjs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there no way to do lazy symbol binding on windows?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am not sure

@saghul
Copy link
Contributor

saghul commented Sep 10, 2024

Done in #490

@saghul saghul closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants