Skip to content

Fix JS_DetectModule if the first statement is an await #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2024
Merged

Fix JS_DetectModule if the first statement is an await #517

merged 1 commit into from
Sep 10, 2024

Conversation

saghul
Copy link
Contributor

@saghul saghul commented Sep 10, 2024

No description provided.

@bnoordhuis
Copy link
Contributor

Would it be possible to add a test? qjs should eval it as a module when it has a *.js suffix. (It always treats *.mjs as modules.)

@saghul
Copy link
Contributor Author

saghul commented Sep 10, 2024

Would it be possible to add a test? qjs should eval it as a module when it has a *.js suffix. (It always treats *.mjs as modules.)

Sure thing!

@saghul
Copy link
Contributor Author

saghul commented Sep 10, 2024

Added test!

@saghul saghul merged commit 6dd2ce3 into master Sep 10, 2024
50 checks passed
@saghul saghul deleted the detect-tla branch September 10, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saghul @bnoordhuis