Make Iterator.from spec compliant #689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
commented
Nov 14, 2024
| @@ -42,14 +42,6 @@ test262/test/built-ins/Date/prototype/setUTCMonth/date-value-read-before-tonumbe | |||
| test262/test/built-ins/Date/prototype/setUTCMonth/date-value-read-before-tonumber-when-date-is-invalid.js:26: strict mode: Test262Error: time updated in valueOf Expected SameValue(«NaN», «0») to be true | |||
| test262/test/built-ins/Date/prototype/setUTCSeconds/date-value-read-before-tonumber-when-date-is-invalid.js:26: Test262Error: time updated in valueOf Expected SameValue(«NaN», «0») to be true | |||
| test262/test/built-ins/Date/prototype/setUTCSeconds/date-value-read-before-tonumber-when-date-is-invalid.js:26: strict mode: Test262Error: time updated in valueOf Expected SameValue(«NaN», «0») to be true | |||
| test262/test/built-ins/Iterator/from/get-return-method-when-call-return.js:24: TypeError: not a function | |||
There was a problem hiding this comment.
These were the new ones after the test262 update. There are a couple of more failures below in weird property access, but as of this PR Iterator.from is non-ghetto :-P
saghul
commented
Nov 14, 2024
quickjs.c
Outdated
| @@ -40053,24 +40057,95 @@ static JSValue js_array_iterator_next(JSContext *ctx, JSValue this_val, | |||
| } | |||
| } | |||
|
|
|||
| typedef struct JSIteratorData { | |||
There was a problem hiding this comment.
@bnoordhuis Let me know what you think of this approach, I couldn't find a way around not having extra stored state.
Merged
|
Doh, I'm an idiot. Looks like we do need a new class because after fixing the prototype whoes I cannot make test262/test/built-ins/Iterator/from/result-proto.js pass. New class it is! |
saghul
force-pushed
the
fix-iterator-from
branch
from
2bc339f to
fb20577
Compare
|
Updated, PTAL! Note it includes #690 |
bnoordhuis
approved these changes
Nov 15, 2024
Create a proper wrapper around the inner iterator and proxy the calls to next / return.
saghul
force-pushed
the
fix-iterator-from
branch
from
1f23f6e to
ca878d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a proper wrapper around the inner iterator and proxy the calls to next / return.