Skip to content

Fix leak when interpreter exits due to exception #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2024
Merged

Fix leak when interpreter exits due to exception #722

merged 1 commit into from
Nov 25, 2024

Conversation

saghul
Copy link
Contributor

@saghul saghul commented Nov 25, 2024

Fixes: #720

bnoordhuis
bnoordhuis approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qjsc.c and run-test262.c need to be updated too, right? They both call js_std_loop without handling the return value.

@saghul
Copy link
Contributor Author

saghul commented Nov 25, 2024

qjsc.c and run-test262.c need to be updated too, right? They both call js_std_loop without handling the return value.

Ops, yeah!

@saghul saghul merged commit f7f70fc into master Nov 25, 2024
51 checks passed
@saghul saghul deleted the fix-cli-leak branch November 25, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assert failed while error statements
2 participants
@saghul @bnoordhuis