Simplify close_lexical_var #726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its implementation was borderline wrong: calling it with is_arg=TRUE segfaults because it looks up the var ref index in the wrong array. Fortunately, there is only one caller and it only passes FALSE.
saghul
approved these changes
Nov 25, 2024
saghul
added a commit
that referenced
this pull request
Mar 23, 2025
This reverts commit 0b0b794. This makes our code closer to bellard/quickjs, which makes applying the commit right after this one simpler.
saghul
added a commit
that referenced
this pull request
Mar 23, 2025
This reverts commit 0b0b794. This makes our code closer to bellard/quickjs, which makes applying the commit right after this one simpler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its implementation was borderline wrong: calling it with is_arg=TRUE segfaults because it looks up the var ref index in the wrong array.
Fortunately, there is only one caller and it only passes FALSE.