Disable with DISABLE_SPRING_WATCHER_LISTEN env var
#28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a project where some Engineers are running configurations that do not support `inotify`, which causes an error when this gem is loaded. We still want these Engineers to be able to use Spring in polling mode. We tried setting `require: false` in the `Gemfile` but [Spring loads the gem anyway](https://github.com/rails/spring/blob/a318a1837524ea6e39a7073af94e75131fcc95d1/lib/spring/commands.rb#L35-L46). This change introduces a new env var `DISABLE_SPRING_WATCHER_LISTEN` which, along the lines of `DISABLE_SPRING`, disables the functionality in this gem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a project where some Engineers are running configurations that do not support
inotify, which causes an error when this gem is loaded. We still want these Engineers to be able to use Spring in polling mode. We tried settingrequire: falsein theGemfilebut Spring loads the gem anyway.This change introduces a new env var
DISABLE_SPRING_WATCHER_LISTENwhich, along the lines ofDISABLE_SPRING, disables the functionality in this gem.There are probably a few ways to solve this problem but I wanted to submit this for your consideration. Feedback welcome!