-
Notifications
You must be signed in to change notification settings - Fork 345
Update .travis.yml #520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .travis.yml #520
Conversation
r? @jonleighton (@rails-bot has picked a reviewer for you, use r? to override) |
https://travis-ci.org/rails/spring/builds/224401092 Maybe it's time to drop those case from |
92e766a
to
77148b5
Compare
We still need to support both versions. |
@rafaelfranca ah sorry I will restore Ruby 1.9.3 and 2.0.0. |
Can't we do the same hack that was done for mime-types for nokogiri? |
@rafaelfranca ok let me try it. |
bd3359b
to
0c4863c
Compare
* Update Rubies to latest version. * Add ruby-head as allow_failures. * It's good to know new version Ruby's issue as faster before the release. * fast_finish is to get the Travis result as faster without waiting the result of the "allow_failures" items. See https://blog.travis-ci.com/2013-11-27-fast-finishing-builds/ * Do hack for Ruby 1.9.3 and 2.0.0. Because the Rails 4.2 dependency's nokogiri latest version requires Ruby version >= 2.1.0.
0c4863c
to
235bac3
Compare
@rafaelfranca I fixed the tests by your recommended way, and all the test was passed. Can you merge this PR? |
ping someone, could you merge it? |
Thanks |
I updated Rubies to latest version.
I also added
ruby-head
asallow_failures
.I think this is useful.
Because we can support the next version as faster.
We can see this kind of logic in
rails/rails
,rspec
andcucumber
and etc.https://github.com/rails/rails/blob/master/.travis.yml
https://github.com/rspec/rspec-core/blob/master/.travis.yml
https://github.com/cucumber/cucumber-ruby/blob/master/.travis.yml
Is it possible to merge?
Thanks.