Skip to content

Update .travis.yml #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2017
Merged

Conversation

junaruga
Copy link
Contributor

I updated Rubies to latest version.
I also added ruby-head as allow_failures.

I think this is useful.
Because we can support the next version as faster.

We can see this kind of logic in rails/rails, rspec and cucumber and etc.
https://github.com/rails/rails/blob/master/.travis.yml
https://github.com/rspec/rspec-core/blob/master/.travis.yml
https://github.com/cucumber/cucumber-ruby/blob/master/.travis.yml

Is it possible to merge?

Thanks.

@rails-bot
Copy link

r? @jonleighton

(@rails-bot has picked a reviewer for you, use r? to override)

@junaruga
Copy link
Contributor Author

junaruga commented Apr 21, 2017

https://travis-ci.org/rails/spring/builds/224401092
Ruby 1.9.3 and 2.0.0 with RAILS_VERSION 4.2 are failed, because the Rails 4.2 dependency nokogiri requires Ruby version >= 2.1.0.

Maybe it's time to drop those case from .travis.yml.

@junaruga junaruga force-pushed the feature/update-travis branch 2 times, most recently from 92e766a to 77148b5 Compare April 21, 2017 16:39
@rafaelfranca
Copy link
Member

We still need to support both versions.

@junaruga
Copy link
Contributor Author

@rafaelfranca ah sorry I will restore Ruby 1.9.3 and 2.0.0.
So it is ok to that those Rubies are tested with rake test:unit only on Travis?

@rafaelfranca
Copy link
Member

Can't we do the same hack that was done for mime-types for nokogiri?

@junaruga
Copy link
Contributor Author

@rafaelfranca ok let me try it.

@junaruga junaruga force-pushed the feature/update-travis branch 7 times, most recently from bd3359b to 0c4863c Compare April 24, 2017 16:52
* Update Rubies to latest version.
* Add ruby-head as allow_failures.
  * It's good to know new version Ruby's issue as faster before the release.
  * fast_finish is to get the Travis result as faster
    without waiting the result of the "allow_failures" items.
    See https://blog.travis-ci.com/2013-11-27-fast-finishing-builds/
* Do hack for Ruby 1.9.3 and 2.0.0.
  Because the Rails 4.2 dependency's nokogiri latest version requires Ruby
  version >= 2.1.0.
@junaruga junaruga force-pushed the feature/update-travis branch from 0c4863c to 235bac3 Compare April 24, 2017 17:24
@junaruga
Copy link
Contributor Author

@rafaelfranca I fixed the tests by your recommended way, and all the test was passed.
The modification of lib/spring/test/application_generator.rb is because of below nokogiri install error during acceptance test.
https://travis-ci.org/rails/spring/builds/224469456

Can you merge this PR?
Thanks.

@junaruga
Copy link
Contributor Author

junaruga commented May 9, 2017

ping someone, could you merge it?

@jonleighton jonleighton merged commit c4a3ee0 into rails:master May 15, 2017
@jonleighton
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants