Gracefully deal with dangling symlinks #522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy
force-pushed
the
watch-dangling-symlinks
branch
2 times, most recently
from
0ce76f5 to
c6733ec
Compare
kaspth
approved these changes
May 20, 2017
jonleighton
reviewed
May 20, 2017
lib/spring/application.rb
Outdated
|
|
||
| @watcher.on_debug do |message| | ||
| spring_env.log "[watcher:#{app_env}] #{message}" | ||
| end if @watcher.respond_to?(:on_debug) |
There was a problem hiding this comment.
Why is the conditional needed?
There was a problem hiding this comment.
Only the poller watcher implements it. Calling it on the listen watcher would bomb.
There was a problem hiding this comment.
But it's defined in the abstract class which the listen watcher inherits from?
lib/spring/watcher/abstract.rb
Outdated
| item.readlink.exist?.tap do |exists| | ||
| debug do | ||
| "add: ignoring dangling symlink: #{item.inspect} -> #{item.readlink.inspect}" | ||
| end if !exists |
There was a problem hiding this comment.
Not really a fan of this style of postfix conditional on a multi-line block personally (I think it's harder to spot what the conditional is doing...)
jeremy
force-pushed
the
watch-dangling-symlinks
branch
2 times, most recently
from
21dc781 to
f923cf1
Compare
…Spring application logger
* Don't add files that are dangling symlinks * When watching a directory, ignore dangling symlinks rather than treating them as forever-stale
jeremy
force-pushed
the
watch-dangling-symlinks
branch
from
f923cf1 to
59bde9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gracefully deal with dangling symlinks
Add a watcher logging facility so such things can be diagnosed and debugged.