chore: integrate jsc into example on android #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cortinico
approved these changes
Feb 12, 2025
| * @param exceptionHandler Callback that can be used by React Native host applications to react to | ||
| * exceptions thrown by the internals of React Native. | ||
| * | ||
| * TODO(T186951312): Should this be @UnstableReactNativeAPI? |
| exceptionHandler = exceptionHandler) | ||
| val componentFactory = ComponentFactory() | ||
| DefaultComponentsRegistry.register(componentFactory) | ||
| // TODO: T164788699 find alternative of accessing ReactHostImpl for initialising reactHost |
example/android/app/src/main/java/com/jscexample/MainApplication.kt
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| override val reactHost: ReactHost | ||
| get() = getDefaultReactHost(applicationContext, reactNativeHost) | ||
| get() { |
There was a problem hiding this comment.
Can we create a util function like this one?
get() = getDefaultJscReactHost(applicationContext, reactNativeHost)
Comment on lines
+26
to
+30
| * A utility class that allows you to simplify the setup of a [ReactHost] for new apps in Open | ||
| * Source. | ||
| * | ||
| * [ReactHost] is an interface responsible of handling the lifecycle of a React Native app when | ||
| * running in bridgeless mode. |
Co-authored-by: Nicola Corti <[email protected]>
|
i'm lean toward to land #4 than this pr and we don't have to maintain a JSCReactHost. |
|
closing this in favor of #4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-native.config.jsfor autolinkingMainApplication.getJavaScriptExecutorFactory()to useJSCExecutorFactoryJSCReactHostbasically from the DefaultReactHost but replace withJSCRuntimeFactory