Callkit view doesn't close

[siemya]

@ianlin Hey,

When i call the RNCallKit.endCall(this.uuid) function callkit view does not close.

Thanks for the module btw! 👍

[ianlin]

Hey @siemya,

Are you testing on the incoming calls or outgoing calls? The system UI is appeared only for incoming calls while endCall() method is used for outgoing calls.

For incoming calls, when you press the hangup button from the system UI, there is an endCall event (different from endCall() method) sent to JS and the module will call [action fulfill] automatically. The system UI will be closed after this.

Can you provide more information about your scenario and some logs could be helpful.

[siemya]

Thanks for the fast response!

When the app is n foreground and i receive a call, i call the RNCallKit.displayIncomingCall function which opens the system UI.

And if i accept that call the system UI goes to background automatically, and i show my own callView.

When the user presses the endCall button or if i receive an endCall event from the other user, i close my own view and call the RNCallKit.endCall(this.uuid) function.

However the system UI keeps appearing on the background...

Thanks.

[ianlin]

I think it happens when the uuid for displayIncomingCall() and endCall() are different. Can you verify your uuid?

[siemya]

@ianlin when i receive a remote call i set a uuid and display the call, and when i receive a remote hangup, i call the endCall event with the same uuid, but the ui doesn't close.

remoteCall() {
  this.uuid = uuid.v4();
  console.log(this.uuid); //a61405bc-252a-4057-b79e-5e971cc82688
  RNCallKit.displayIncomingCall(this.uuid, name);
}

hangUp() {
  console.log(this.uuid); //a61405bc-252a-4057-b79e-5e971cc82688
  RNCallKit.endCall(this.uuid);
  this.uuid = null;
}

[ianlin]

That's odd, I've only run into this problem when the uuid is not the same. Can you please provide any log (JS and Native) to see what happened there?

[siemya]

Hey,

i guess i found the problem, but it still doesn't work sometimes.

On my constructor i add the endCall event listener, and i have two hangup functions (hangUp, remoteHangUp).

İ make a call when the app is on foreground, and end the call immediately. So i expect only the remoteHangUp function to get called. However after remoteHangUp also hangUp function gets called which i added to eventListener, which might mix things up.

//i expect to call hangUp only when user presses the decline button.
RNCallKit.addEventListener('endCall', this.hangUp);

remoteHangUp() {
  RNCallKit.endCall(this.uuid);
  //other actions
}

hangUp() {
  RNCallKit.endCall(this.uuid);
  //other actions
}

[ianlin]

Had some tests and yes the endCall event will be triggered after every endCall action. But still I can't reproduce the problem you have even if I call RNCallKit.endCall() twice.

Instead of calling RNCallKit.endCall() in both of your hangup function, I would suggest put it in the signal event. For my case since I'm using SIP for signalling, I call it when terminated or cancel events received.

[ianlin]

Hey @siemya have you sorted out this problem?

[eugenehp]

@ianlin looks like there was a wrong UUID pointer. Now it works for me 👍

[joshuaalpuerto]

does anyone fixed this issue? Im having trouble calling endCall method

here's the code :

const _uuid = uuid.v4()

RNCallKit.displayIncomingCall(_uuid, "Translator") // <--- 2d506a4a-8c50-40cc-894c-c359c210fd74

setTimeout(() => {
      if (!_answered) {
        console.tron.log('should end call / missed call')
        console.tron.log({
          uuid: this._uuid // <--- 2d506a4a-8c50-40cc-894c-c359c210fd74
        })
        RNCallKit.endCall(_uuid)
      }
}, 10000)

Here's my log:

2017-07-10 11:00:55.572985+0800 TranslatorApp[2806:1089269] [RNCallKit][endCall] uuidString = 2d506a4a-8c50-40cc-894c-c359c210fd74
2017-07-10 11:00:55.573421+0800 TranslatorApp[2806:1089269] [RNCallKit][requestTransaction] transaction = <CXTransaction 0x181bdd30 UUID=C6AD163D-E00B-46EC-9E2A-C54FACE4E97B isComplete=0 actions=(
    "<CXEndCallAction 0x16fd0040 UUID=893A8730-1118-48CC-A60A-6E56FF1FFD30 state=0 commitDate=(null) callUUID=2D506A4A-8C50-40CC-894C-C359C210FD74 dateEnded=(null)>"
)>
2017-07-10 11:00:55.580380+0800 TranslatorApp[2806:1089398] [RNCallKit][requestTransaction] Error requesting transaction ((
    "<CXEndCallAction 0x16fd0040 UUID=893A8730-1118-48CC-A60A-6E56FF1FFD30 state=0 commitDate=(null) callUUID=2D506A4A-8C50-40CC-894C-C359C210FD74 dateEnded=(null)>"
)): (Error Domain=com.apple.CallKit.error.requesttransaction Code=4 "(null)")
2017-07-10 11:01:26.675633+0800 TranslatorApp[2806:1085467] [RNCallKit][CXProviderDelegate][provider:performEndCallAction]

Cheers!

[eugenehp]

Are you sending correct UUID here? I feel like it would be great to store those uuids on level of this library, so if endCall is missing uuid, it could grab one from the cache.

…

On Sun, Jul 9, 2017 at 8:12 PM Joshua Alpuerto ***@***.***> wrote: does anyone fixed this issue? Im having trouble calling endCall method here's the code : const _uuid = uuid.v4() RNCallKit.displayIncomingCall(_uuid, "Translator") // <--- 2d506a4a-8c50-40cc-894c-c359c210fd74 setTimeout(() => { if (!_answered) { console.tron.log('should end call / missed call') console.tron.log({ uuid: this._uuid // <--- 2d506a4a-8c50-40cc-894c-c359c210fd74 }) RNCallKit.endCall(_uuid) } }, 10000) Here's my log: 2017-07-10 11:00:55.572985+0800 TranslatorApp[2806:1089269] [RNCallKit][endCall] uuidString = 2d506a4a-8c50-40cc-894c-c359c210fd74 2017-07-10 11:00:55.573421+0800 TranslatorApp[2806:1089269] [RNCallKit][requestTransaction] transaction = <CXTransaction 0x181bdd30 UUID=C6AD163D-E00B-46EC-9E2A-C54FACE4E97B isComplete=0 actions=( "<CXEndCallAction 0x16fd0040 UUID=893A8730-1118-48CC-A60A-6E56FF1FFD30 state=0 commitDate=(null) callUUID=2D506A4A-8C50-40CC-894C-C359C210FD74 dateEnded=(null)>" )> 2017-07-10 11:00:55.580380+0800 TranslatorApp[2806:1089398] [RNCallKit][requestTransaction] Error requesting transaction (( "<CXEndCallAction 0x16fd0040 UUID=893A8730-1118-48CC-A60A-6E56FF1FFD30 state=0 commitDate=(null) callUUID=2D506A4A-8C50-40CC-894C-C359C210FD74 dateEnded=(null)>" )): (Error Domain=com.apple.CallKit.error.requesttransaction Code=4 "(null)") 2017-07-10 11:01:26.675633+0800 TranslatorApp[2806:1085467] [RNCallKit][CXProviderDelegate][provider:performEndCallAction] Cheers! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABxW71MyJVfS9NLdV7hQJ1RR-_UdzikHks5sMZaKgaJpZM4MW1EK> .

[joshuaalpuerto]

HI @eugenehp

Yes I am. I actually thought I edited my post but your PR, solves my issue.

[eugenehp]

@joshuaalpuerto glad it helped you.

I'm still curious to hear what @ianlin thinks about improving architecture of the wrapper.

[joshuaalpuerto]

@eugenehp Sorry Im still new with mobile development, Im no expert of swift nor objective-c so I can't really comment on that. Anyway I experience a weird issue last night, Im trying to call endCall method and it is not triggering. I think it has something to do if the call goes wrong or something.

I have to put back this part on ios/RNCallKit/RNCallKit.m

+reportCallWithUUID:startCallAction.callUUID updated:callUpdate];
-reportCallWithUUID:startCallAction.UUID updated:callUpdate];

And It works again.