Skip to content

docs: translation of <Fragment> (<>) page #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
May 8, 2023
Merged

docs: translation of <Fragment> (<>) page #486

merged 23 commits into from
May 8, 2023

Conversation

AudiWu
Copy link
Contributor

@AudiWu AudiWu commented Apr 28, 2023 •
edited
Loading

Description

Translation for <Fragment> (<>) page
Page URL: https://id.react.dev/reference/react/Fragment

Related Issues

Closes #413

Note

Hello, I just finished the translation. This is my first time translating technical documentation, sorry if there are any word mistakes. Let me know if there is some suggestion.

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

mhaidarhanif
mhaidarhanif requested changes Apr 28, 2023
View reviewed changes
Copy link
Collaborator

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some early suggestions:

@AudiWu AudiWu requested a review from mhaidarhanif April 29, 2023 05:28
r17x
r17x requested changes Apr 29, 2023
View reviewed changes
Copy link
Collaborator

@r17x r17x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure:

  • merender -> me-*render* except in Heading
  • dirender -> di-*render* except in Heading
  • set italic for non-bahasa word.

@r17x r17x mentioned this pull request Apr 29, 2023
Merged
@AudiWu
Copy link
Contributor Author

AudiWu commented Apr 30, 2023

Make sure:

  • merender -> me-*render* except in Heading
  • dirender -> di-*render* except in Heading
  • set italic for non-bahasa word.

Hi @r17x , I already set italic for non-bahasa word. Please help me to review it again.

@AudiWu AudiWu requested review from mazipan and r17x April 30, 2023 08:09
zainfathoni
zainfathoni requested changes May 1, 2023
View reviewed changes
Copy link
Collaborator

@zainfathoni zainfathoni left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some minor suggestions. Feel free to correct me if any of you disagree with them. Thanks!

@AudiWu
Copy link
Contributor Author

AudiWu commented May 1, 2023 •
edited
Loading

I have some minor suggestions. Feel free to correct me if any of you disagree with them. Thanks!

Hi @zainfathoni , I already change the word according to your suggestion. Please review it again.
Thank you for your suggestion.

@AudiWu AudiWu requested review from zainfathoni and mazipan May 1, 2023 22:38
zainfathoni
zainfathoni requested changes May 2, 2023
View reviewed changes
Copy link
Collaborator

@zainfathoni zainfathoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more minor suggestions that I just noticed on my second review.

@AudiWu
Copy link
Contributor Author

AudiWu commented May 2, 2023

Some more minor suggestions that I just noticed on my second review.

Hi @zainfathoni , I already change the word according to your second review. Please review it again.

@AudiWu AudiWu requested a review from zainfathoni May 2, 2023 11:28
@mhaidarhanif
Copy link
Collaborator

Let's wait for @zainfathoni again

zainfathoni
zainfathoni approved these changes May 8, 2023
View reviewed changes
Copy link
Collaborator

@zainfathoni zainfathoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, it looks good to me. But there are still missing instances of "menentukan" ➡️ "menetapkan" translations. Once they are addressed, we may merge this PR. 💯

Thanks! 🙏

@zainfathoni zainfathoni merged commit 13f63d0 into reactjs:main May 8, 2023
FelixFern pushed a commit to FelixFern/id.react.dev that referenced this pull request Jun 13, 2023
@AudiWu @mhaidarhanif
@zainfathoni @mazipan @FelixFern
docs: translation of <Fragment> (<>) page (reactjs#486)
6e532ba 
Co-authored-by: M Haidar Hanif <[email protected]>
Co-authored-by: Zain Fathoni <[email protected]>
Co-authored-by: Zain Fathoni <[email protected]>
Co-authored-by: Irfan Maulana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhaidarhanif mhaidarhanif mhaidarhanif approved these changes

@zainfathoni zainfathoni zainfathoni approved these changes

@r17x r17x r17x approved these changes

@resir014 resir014 Awaiting requested review from resir014

@mazipan mazipan Awaiting requested review from mazipan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<Fragment> (<>)
5 participants
@AudiWu @mhaidarhanif @zainfathoni @mazipan @r17x