Why inline-block?

[docentq2]

https://github.com/rackt/react-autocomplete/blob/master/lib/Autocomplete.js#L301

Hi.
If I want make this div display block? How I make it, without change code in node_modules?

[otmjka]

PR, pleeeease ^_^ #50

[docentq2]

@otmjka thanks!

[robcalcroft]

+1

[skeie]

+1

[NerdHerd91]

+1 just got bit by this today, had to use selectors to target that div for adjustments

[iamraffe]

+1

[lior-amsalem]

+1

[hontas]

The autocomplete build in ./build/lib/Autocomplete.js is broken.
It always sets display to 'inline-block' and not to passed property wrapperStyles.
When I build locally with rackt build it turns out fine - so a new build should resolve this.

[laughnan]

Has this been resolved or investigated? I'm seeing the same issue.

[hontas]

just made a PR to resolve this: #97

[Jhays10]

For a quick fix, I found if you pass wrapperStyle={{}} in as a prop, that will remove the inline-block.

Example:

<Autocomplete
  value={s.value}
  items={s.options}
  getItemValue={this.getItemValue}
  onSelect={p.onSelect}
  onChange={this.handleChange}
  renderItem={this.renderItem}
  renderMenu={this.renderMenu}
  wrapperStyle={{}} />

[hontas]

@Jhays10 take a look @ https://github.com/reactjs/react-autocomplete/blob/master/build/lib/Autocomplete.js#L303 and tell me how that is possible. As you can see, inline-block i hard-coded in current build, something my PR above fixes. I'm just waiting for someone to merge it since I can't.

[Jhays10]

@hontas The wrapperStyle is set in the getDefaultProps.
https://github.com/reactjs/react-autocomplete/blob/master/lib/Autocomplete.js#L26

So when you specify wrapperStyle={{}} your removing that default and setting it to your own empty object. To fix this, I would expect getDefaultProps to set wrapperStyle: {}.

[hontas]

@Jhays10 yes I know. But when you require react-autocomplete you get the built file, specified in package.json as main. Take a look at the code there and you'll see that it's not the same and that's why I made a PR with a new build to fix this.