Stop keeping value in state

[CMTegner]

a.k.a. replace props.initialValue with props.value. This change makes the
behaviour of Autocomplete closer to that of native input elements, i.e. you are
forced to always supply the current value which the input should display, and
the element will provide the updated value via the onChange callback (and
onSelect).

Upgrade path:

Before:

class MyWidget extends Component {
  render() {
    return (
      <Autocomplete
        initialValue="hello"
      />
    )
  }
}

After:

class MyWidget extends Component {
  constructor() {
    this.state = { value: 'hello' }
  }
  render() {
    return (
      <Autocomplete
        value={this.state.value}
        onChange={event => this.setState({ value: event.target.value })}
        onSelect={value => this.setState({ value })}
      />
    )
  }
}

This is obviously a breaking change.

Closes #49

[colepacak]

+1

[cakeinpanic]

+1

[NerdHerd91]

+1 - any timeline on when this change might occur, realizing this would require a version bump?

[CMTegner]

Looks like @sprjr has been accepting PRs lately. Perhaps he can evaluate whether or not this change aligns with the 1.0 API.

[whichsteveyp]

@CMTegner sure thing - do you want to rebase this branch and we can take a look at it?

[CMTegner]

@sprjr: Rebased and ready to review/discuss :)

[whichsteveyp]

I like it. Since this was said I'd like to see if @ryanflorence can take a look as well. I'm otherwise ok with merging it in and releasing a breaking version soon. I'd like to get out of the 0.x pattern and just go with better semver on it, perhaps we can include some other PRs with it as well since that'd be 1.0.0.

[CMTegner]

Sounds good to me! I know @ryanflorence has some ideas regarding how the API would change before 1.0. I'd be happy to chip in if help is needed.

[NerdHerd91]

Can we get an update on this?

[whichsteveyp]

@NerdHerd91 I pinged Ryan again to see if he can weigh in (since he had originally asked for things like this. That being said, I'd love to get a bit of progress on this as well - especially now that #77 has been opened. Would love it if we could review that and get it merged in soon so we can follow up on others of these too with a bit more confidence.

[whichsteveyp]

@CMTegner lets plan to move forward on this. We have tests merged in now. Want to rebase off master and verify they are still working (and/or update them)?

[CMTegner]

@sprjr done!

[whichsteveyp]

I pushed and release 1.0.0-rc1 so that this is no longer delayed. I may try to tackle a few other issues in to the final release of 1.0.0 before releasing, but this is done now - sorry for the delay.

[CMTegner]

Great! 👍