Skip to content

fix: ensure the repo links in the README are functional on the website #3005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025

Conversation

thegiantbeast
Copy link
Contributor

@thegiantbeast thegiantbeast commented Jun 25, 2025

Description

This PR aims to fix the broken links on https://redis.js.org/.
Originally, the links were relative to the repository, which works fine on GitHub. However, once the documentation is extracted to the website, those links break. For example, any link under https://redis.js.org/#node-redis-migration does not work.

This work also relates to #2980 and probably missed that the same content was in a different file.

NOTE: This is exactly the same changes present in https://github.com/redis/node-redis/blob/708b22f366d2825f5b2b58c49a764373e6814bfa/packages/redis/README.md

@nkaradzhov nkaradzhov self-assigned this Jun 25, 2025
Copy link
Collaborator

@nkaradzhov nkaradzhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM

@nkaradzhov
Copy link
Collaborator

@thegiantbeast thanks!

@nkaradzhov nkaradzhov merged commit 6f3380b into redis:master Jun 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants