[cling] Work around constructor priority bug #16420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hahnjo
requested review from
vgvassilev,
dpiparo,
vepadulano and
devajithvs
Test Results 13 files 13 suites 3d 4h 20m 22s ⏱️ Results for commit 705771a. ♻️ This comment has been updated with latest results. |
LLVM had a bug where constructors with the same priority would not be stably sorted. This has been fixed upstream by llvm/llvm-project#95532, but to avoid relying on a backport this commit works around the issue: The idea is that we lower the default priority of concerned constructors to make them sort correctly.
hahnjo
force-pushed
the
cling-constructors
branch
from
9605585 to
705771a
Compare
|
I feel uneasy about this change. @smuzaffar, can you run the cmssw CI on this PR? |
cmssw tests started via cms-sw#210 |
|
cmssw tests look good cms-sw#210 (comment) |
|
Thank you, @smuzaffar! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM had a bug where constructors with the same priority would not be stably sorted. This has been fixed upstream by llvm/llvm-project#95532, but to avoid relying on a backport this commit works around the issue: The idea is that we lower the default priority of concerned constructors to make them sort correctly.
As discussed, this provides a bit of magic 🪄 to work around the bug if we don't have the backport, for example in the Conda releases. I propose we still leave the backport in our copy of LLVM though.