Skip to content
This repository was archived by the owner on Mar 15, 2022. It is now read-only.

Replaces compiled Java with JRuby interop #17

Merged
merged 1 commit into from
Jan 29, 2015
Merged

Replaces compiled Java with JRuby interop #17

merged 1 commit into from
Jan 29, 2015

Conversation

lucasallan
Copy link
Member

@jdantonio Hey Jerry, could you take a look?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 96.72% when pulling 2716bf7 on jruby into 6d4d69c on master.

@jdantonio
Copy link
Member

👍 Thank you very much for doing this! You should have commit access. Please merge when you are ready.

lucasallan added a commit that referenced this pull request Jan 29, 2015
@lucasallan
Merge pull request #17 from ruby-concurrency/jruby
cd9191a 
Replaces compiled Java with JRuby interop
@lucasallan lucasallan merged commit cd9191a into master Jan 29, 2015
@lucasallan lucasallan deleted the jruby branch January 29, 2015 01:46
@pitr-ch
Copy link
Member

pitr-ch commented Jan 29, 2015

Did it have any performance impact?

@jdantonio jdantonio mentioned this pull request Jan 29, 2015
Closed
@jdantonio
Copy link
Member

@pitr-ch Thank you for asking that question. I need to remind myself to always ask that. Based on the tests I performed in PR #19 it appears that the original implementation is much faster. Once someone verifies my tests/findings in that PR I think we'll probably want to revert this change.

@lucasallan lucasallan mentioned this pull request Feb 9, 2015
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucasallan @coveralls @jdantonio @pitr-ch