Bug report: omitted array parameters with `array_use_braces: true`

[olivier-thatch]

When array_use_braces is set to true, array parameters are omitted when they are body parameters but don't explicitly specify documentation: { param_type: "body" }.

Example:

# with add_swagger_documentation(array_use_braces: true)

params do
  requires :param1, type: Array[String]
  requires :param2, type: Array[Integer], documentation: { param_type: "body" }
end
post :foo do
  { declared_params: declared(params)
end

The spec will look like:

"postFoo": {
  "required": ["param2"],
  "type": "object",
  "properties": {
    "param2": {
      "type": "array",
      "items": { "type": "integer", "format": "int32" }
    }
  }
}

It is particularly annoying if one wants to share some params between GET and POST/PUT/PATCH endpoints and rely on the implicit behavior to have the params be query params or body params as appropriate.

[olivier-thatch]

I didn't spend too much time looking into this, but I think this happens because:

• array_use_braces: true causes [] to be appended to array parameter names:

  grape-swagger/lib/grape-swagger/endpoint/params_parser.rb

  Line 26 in 3e842a1

  name += '[]' if array_use_braces?

• which in turn causes array parameters to be treated as nested params:

  grape-swagger/lib/grape-swagger/doc_methods/move_params.rb

  Line 41 in 3e842a1

  params, nested_params = params.partition { |x| !x[:name].to_s.include?('[') }

Probably the check needs to be updated to exclude foo[] and only treat foo[bar] as nested params?

[dblock]

Please do try to PR a fix!