[Core/hash] Add specs for Hash #<=, #>=, #<, #> for Ruby 2.3

[JuanitoFatas]

specs are from https://github.com/ruby/ruby/blob/d68c3ecf/test/ruby/test_hash.rb#L1311-L1334.

[eregon]

Thanks, this a good start!
I would like to test behavior when hashes are more unrelated to each other, for instance sth like
{a:1, b:2} < {c:3, d:4} and also document what is the behavior when values differ but the keys are the same.

[eregon]

In general, it's better if the spec descriptions explain the behavior, for instance here it could be:
returns true when comparing against itself or ... against the same hash.

[JuanitoFatas]

👍 sure, thanks.

[JuanitoFatas]

@eregon Hello Benoit, I have updated specs, please take a look. Thank you.

[eregon]

Great work! 😀

I only have one concern left: we should specify what happens when the keys match but the values don't. Could you add an example per method about that? 😔

[JuanitoFatas]

I notice one thing that in rubyspec test suite, we use lt, lte, gt, gte to describe <, <=, >, >=.

But in CRuby, those methods are defined as lt, le, gt, ge, do you think we should change rubyspec test suite file names and respective tests to be consistent?

[eregon]

Awesome, thank you for writing these specs! 🎉

Internal names of MRI are not considered, as they could be anything.
The RubySpec naming choice is described in https://github.com/ruby/mspec/blob/master/lib/mspec/utils/name_map.rb and it would be simpler to keep as-is unless there is a compelling reason to change (ge/gte is just personal preference I believe).

[JuanitoFatas]

The RubySpec naming choice is described in https://github.com/ruby/mspec/blob/master/lib/mspec/utils/name_map.rb

Thanks for the link!

🙇