Skip to content

do not mind excepction class #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2015
Merged

do not mind excepction class #170

merged 1 commit into from
Dec 8, 2015

Conversation

nobu
Copy link
Member

@nobu nobu commented Dec 8, 2015

It should be TypeError as other methods, but Date#<< misses
the check.

@nobu
do not mind excepction class
1fdd93d 
It should be `TypeError` as other methods, but `Date#<<` misses
the check.
nobu added a commit that referenced this pull request Dec 8, 2015
@nobu
Merge pull request #170 from nobu/bug/Date-minus_month-exception
f8358bd 
do not mind excepction class
@nobu nobu merged commit f8358bd into ruby:master Dec 8, 2015
@nobu nobu deleted the bug/Date-minus_month-exception branch December 8, 2015 01:17
@eregon
Copy link
Member

eregon commented Dec 8, 2015

@nobu Is this going to be backported? It seems not.

@eregon
Copy link
Member

eregon commented Dec 8, 2015

@nobu In the case it's not backported, it's good to generalize as you did, but then also to test more precisely for the new version like I did in 72b2688.

@eregon eregon mentioned this pull request Dec 16, 2015
Closed
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nobu @eregon