Skip to content

spec for "no longer try to call #to_ary method on elements beyond the given level." #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2016
Merged

spec for "no longer try to call #to_ary method on elements beyond the given level." #307

merged 2 commits into from
Oct 12, 2016

Conversation

sgarciac
Copy link
Contributor

No description provided.

eregon
eregon reviewed Oct 11, 2016
View reviewed changes
core/array/flatten_spec.rb
obj = mock("1")
obj.should_not_receive(:to_ary)
[[obj]].flatten(1)
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could add a version guard since this is only fixed from 2.3 and later? See this example.

@eregon
Copy link
Member

eregon commented Oct 11, 2016

Thanks a lot, the new spec is nice!

I have a small nitpick, could you reword your commit messages to reference issues in this format?

<commit title>
* See #175
* See [Feature 11801]

@sgarciac
Copy link
Contributor Author

Hello! Ok, I'll come back with those changes.

Sergio Garcia added 2 commits October 11, 2016 18:18
flatten no longer calls #to_ary method on elements beyond the given l…
894db53 
…evel.

* See #175
* See [Bug 10748]
Hash#inspect doesn't raise error even if its content returns a string
aef521e 
which is not compatible with Encoding.default_external as inspected
result.

* See [Feature 11801]
* See #174
@sgarciac
Copy link
Contributor Author

done

@eregon eregon merged commit 9a6c6b1 into ruby:master Oct 12, 2016
@eregon
Copy link
Member

eregon commented Oct 12, 2016

Merged, thank you for your contribution!

@eregon eregon mentioned this pull request Oct 12, 2016
Closed
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgarciac @eregon