fix!: Make the first snippet or origin primary #261
+106
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to determine what was "primary" by looking for
AnnotationKind::Primary
orOrigin::primary
was a bit brittle and had rendering bugs if anOrigin
orSnippet
came before the "primary" one. To avoid those problems and make things more consistent, I made it so the firstOrigin
orSnippet
we encounter is the "primary". This change also has the benefit of allowing us to get rid ofOrigin::primary
in a future PR, which will makeOrigin
rendering better into the currentGroup
model.