Skip to content

fix!: Make the first snippet or origin primary #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Muscraft
Copy link
Member

Trying to determine what was "primary" by looking for AnnotationKind::Primary or Origin::primary was a bit brittle and had rendering bugs if an Origin or Snippet came before the "primary" one. To avoid those problems and make things more consistent, I made it so the first Origin or Snippet we encounter is the "primary". This change also has the benefit of allowing us to get rid of Origin::primary in a future PR, which will make Origin rendering better into the current Group model.

@epage
Copy link
Contributor

epage commented Jul 31, 2025

Note that as this has end-user impact, this is not a chore

@Muscraft Muscraft changed the title chore: Make the first snippet or origin primary fix!: Make the first snippet or origin primary Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants