Skip to content

app/routes/crate/settings: hide the settings page for non-owners #10792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions app/routes/crate/settings.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,23 @@
import { inject as service } from '@ember/service';

import AuthenticatedRoute from '../-authenticated-route';

export default class SettingsRoute extends AuthenticatedRoute {
@service router;
@service session;

async afterModel(crate, transition) {
let user = this.session.currentUser;
let owners = await crate.owner_user;
let isOwner = owners.some(owner => owner.id === user.id);
if (!isOwner) {
this.router.replaceWith('catch-all', {
transition,
title: 'This page is only accessible by crate owners',
});
}
}

setupController(controller) {
super.setupController(...arguments);
let crate = this.modelFor('crate');
Expand Down
56 changes: 56 additions & 0 deletions tests/routes/crate/settings-test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
import { currentURL } from '@ember/test-helpers';
import { module, test } from 'qunit';

import { setupApplicationTest } from 'crates-io/tests/helpers';

import { visit } from '../../helpers/visit-ignoring-abort';

module('Route | crate.settings', hooks => {
setupApplicationTest(hooks, { msw: true });

function prepare(context) {
const user = context.db.user.create();

const crate = context.db.crate.create({ name: 'foo' });
context.db.version.create({ crate });
context.db.crateOwnership.create({ crate, user });

return { crate, user };
}

test('unauthenticated', async function (assert) {
const crate = this.db.crate.create({ name: 'foo' });
this.db.version.create({ crate });

await visit('/crates/foo/settings');
assert.strictEqual(currentURL(), '/crates/foo/settings');
assert.dom('[data-test-title]').hasText('This page requires authentication');
assert.dom('[data-test-login]').exists();
});

test('not an owner', async function (assert) {
const { crate } = prepare(this);

const otherUser = this.db.user.create();
this.authenticateAs(otherUser);

await visit(`/crates/${crate.name}/settings`);
assert.strictEqual(currentURL(), `/crates/${crate.name}/settings`);
assert.dom('[data-test-title]').hasText('This page is only accessible by crate owners');
assert.dom('[data-test-go-back]').exists();
});

test('happy path', async function (assert) {
const { crate, user } = prepare(this);
this.authenticateAs(user);

await visit(`/crates/${crate.name}/settings`);
assert.strictEqual(currentURL(), `/crates/${crate.name}/settings`);
// This is the Add Owner button.
assert.dom('[data-test-save-button]').exists();
assert.dom('[data-test-owners]').exists();
assert.dom(`[data-test-owner-user="${user.login}"]`).exists();
assert.dom('[data-test-remove-owner-button]').exists();
assert.dom('[data-test-delete-button]').exists();
});
});
Loading