Implement Trusted Publishing token exposure notifications #11419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-enhancement ✨
Turbo87
force-pushed
the
trustpub-exposure-notifications
branch
from
047319a to
15bd28a
Compare
eth3lbert
reviewed
Jun 24, 2025
This commit implements a `TrustedPublishingTokenExposedEmail` template that will be used to notify users when their trusted publishing tokens are revoked due to GitHub secret scanning alerts. The template handles both single and multiple crate scenarios and provides security guidance.
Turbo87
force-pushed
the
trustpub-exposure-notifications
branch
from
15bd28a to
f0e450d
Compare
eth3lbert
reviewed
Jun 24, 2025
Turbo87
force-pushed
the
trustpub-exposure-notifications
branch
from
f0e450d to
46b2231
Compare
LawnGnome
approved these changes
Jun 24, 2025
There was a problem hiding this comment.
Thanks for doing this!
One thing to note with the proposed implementation: In the scenario where user 1 is an owner of crate 1 and 2, and user 2 is an owner of only crate 2, then the notification of user 2 will only mention crate 2. I wonder if that is the right thing to do or not.
I think that's actually the right behaviour — in practice, I'm not terribly concerned, since crates and their ownerships are public, but I think only notifying users of their own crates is the right thing to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #11405, this PR implements email notifications to all related crate owners if a Trusted Publishing token is publicly exposed and reported to us by the GitHub secret scanning program.
One thing to note with the proposed implementation: In the scenario where user 1 is an owner of crate 1 and 2, and user 2 is an owner of only crate 2, then the notification of user 2 will only mention crate 2. I wonder if that is the right thing to do or not. We could also expose the list of all publishable crates to all users, independent from their ownership status 🤔