update node versions to current stable release #1824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jtgeibel (rust_highfive has picked a reviewer for you, use r? to override) |
|
I've been using a weird combo of node 10 and npm 5 from my distro, so this was a good excuse to switch to the official upstream packages. I was able to reproduce the build error (in node-gyp) locally, and resolved it by upgrading |
locks
force-pushed
the
node-version-update
branch
from
ca1fee6 to
edc8a3d
Compare
|
@jtgeibel thank you for investigating! I have followed your instructions to get the PR green. |
|
@bors: r+ |
|
📌 Commit edc8a3d has been approved by |
bors
added a commit
that referenced
this pull request
Sep 6, 2019
update node versions to current stable release
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.