Skip to content

models/version: Shorten releaseTrack for high major versions #3260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Feb 9, 2021

Example: https://crates.io/crates/rustc-ap-rustc_arena/versions

Having 706.x as the release track barely fits in the release track indicator, so let's shorten this value for major versions above 100.

@Turbo87 Turbo87 added C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works A-frontend 🐹 labels Feb 9, 2021
@Turbo87 Turbo87 force-pushed the release-track branch 2 times, most recently from 1cec489 to a9e4ad6 Compare February 13, 2021 19:02
@bors
Copy link
Contributor

bors commented Feb 25, 2021

☔ The latest upstream changes (presumably #3327) made this pull request unmergeable. Please resolve the merge conflicts.

@Turbo87 Turbo87 force-pushed the release-track branch 3 times, most recently from a79564c to 4791ce1 Compare February 27, 2021 13:19
@pichfl
Copy link

pichfl commented Mar 1, 2021

This is an acceptable stop-gap measure but not a holistic solution to the problem. We might have to revisit in the future but it should be fine for now.

@bors r+

@bors
Copy link
Contributor

bors commented Mar 1, 2021

📌 Commit 84b6f1e has been approved by pichfl

@bors
Copy link
Contributor

bors commented Mar 1, 2021

⌛ Testing commit 84b6f1e with merge 336f498...

@bors
Copy link
Contributor

bors commented Mar 1, 2021

☀️ Test successful - checks-actions
Approved by: pichfl
Pushing 336f498 to master...

@bors bors merged commit 336f498 into rust-lang:master Mar 1, 2021
@Turbo87 Turbo87 deleted the release-track branch March 1, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants