Skip to content

Import htmlSafe from @ember/template #3329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2021
Merged

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Feb 25, 2021

This should resolve a few of the deprecation warnings that got introduced with Ember 3.25

@Turbo87 Turbo87 added A-frontend 🐹 C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear labels Feb 25, 2021
Copy link
Contributor

@locks locks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's actually a bug and no way to get rid of this deprecation until a patch version of 3.25 with the deprecation disabled lands.

@Turbo87
Copy link
Member Author

Turbo87 commented Feb 25, 2021

@locks sure, but I guess adjusting the import paths is still helpful, right?

@Turbo87 Turbo87 force-pushed the htmlsafe branch 2 times, most recently from 3bbb773 to c1f541e Compare February 26, 2021 23:13
Importing from `@ember/string` is deprecated
Importing from `@ember/string` is deprecated
@pichfl
Copy link

pichfl commented Mar 1, 2021

Out with the old, in with the new

@bors r+

@bors
Copy link
Contributor

bors commented Mar 1, 2021

📌 Commit 67d505c has been approved by pichfl

@bors
Copy link
Contributor

bors commented Mar 1, 2021

⌛ Testing commit 67d505c with merge 05144eb...

@bors
Copy link
Contributor

bors commented Mar 1, 2021

☀️ Test successful - checks-actions
Approved by: pichfl
Pushing 05144eb to master...

@bors bors merged commit 05144eb into rust-lang:master Mar 1, 2021
@Turbo87 Turbo87 deleted the htmlsafe branch March 1, 2021 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants