menus: Tweak JS handling of clicks. #1097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, if you clicked a menu to open it, then clicked to close it, the menu heading would still have a grey background highlighting it. That's due to a CSS rule in pure-menu that causes focused elements to have a highlighted color. To fix: unfocus the menu when it is closed via mouse (but leave it focused when it is closed via keyboard). Remove a mouseover handler that is not needed anymore.
jyn514
added
A-frontend
|
Need to check locally to confirm it but the code looks good. |
|
Tested it out and it works great, thanks :) It does keep the highlighting when you use space to close, but I think that's intentional because it shows the tag that's in focus. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, if you clicked a menu to open it, then clicked to
close it, the menu heading would still have a grey background
highlighting it. That's due to a CSS rule in pure-menu that causes
focused elements to have a highlighted color. To fix: unfocus the menu
when it is closed via mouse (but leave it focused when it is closed via
keyboard).
Remove a mouseover handler that is not needed anymore.