Skip to content

always compile consistency check features, since we really use it now #2617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@ exclude = [
".rustwide-docker",
]

[features]
consistency_check = ["crates-index", "itertools"]

[dependencies]
sentry = "0.34.0"
sentry-panic = "0.34.0"
Expand All @@ -31,7 +28,7 @@ tracing-subscriber = { version = "0.3.16", default-features = false, features =
tracing-log = "0.2.0"
regex = "1"
clap = { version = "4.0.22", features = [ "derive" ] }
crates-index = { version = "3.0.0", default-features = false, features = ["git", "git-performance", "parallel"], optional = true }
crates-index = { version = "3.0.0", default-features = false, features = ["git", "git-performance", "parallel"] }
rayon = "1.6.1"
num_cpus = "1.15.0"
crates-index-diff = { version = "25.0.0", features = [ "max-performance" ]}
Expand Down Expand Up @@ -66,7 +63,7 @@ postgres-types = { version = "0.2", features = ["derive"] }
zip = {version = "2.2.0", default-features = false, features = ["bzip2"]}
bzip2 = "0.4.4"
getrandom = "0.2.1"
itertools = { version = "0.13.0", optional = true}
itertools = { version = "0.13.0" }
rusqlite = { version = "0.32.1", features = ["bundled"] }
hex = "0.4.3"

Expand Down
2 changes: 0 additions & 2 deletions src/bin/cratesfyi.rs
Original file line number Diff line number Diff line change
Expand Up @@ -554,7 +554,6 @@ enum DatabaseSubcommand {
},

/// Compares the database with the index and resolves inconsistencies
#[cfg(feature = "consistency_check")]
Synchronize {
/// Don't actually resolve the inconsistencies, just log them
#[arg(long)]
Expand Down Expand Up @@ -648,7 +647,6 @@ impl DatabaseSubcommand {

Self::Limits { command } => command.handle_args(ctx)?,

#[cfg(feature = "consistency_check")]
Self::Synchronize { dry_run } => {
docs_rs::utils::consistency::run_check(&ctx, dry_run)?;
}
Expand Down
1 change: 0 additions & 1 deletion src/index.rs
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ impl Index {
Ok(diff)
}

#[cfg(feature = "consistency_check")]
pub(crate) fn crates(&self) -> Result<crates_index::GitIndex> {
tracing::debug!("Opening with `crates_index`");
// crates_index requires the repo url to match the existing origin or it tries to reinitialize the repo
Expand Down
1 change: 0 additions & 1 deletion src/utils/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ pub(crate) use self::rustc_version::{get_correct_docsrs_style_file, parse_rustc_
pub(crate) use self::cargo_metadata::{Dependency, Target};

mod cargo_metadata;
#[cfg(feature = "consistency_check")]
pub mod consistency;
mod copy;
pub mod daemon;
Expand Down
Loading