Skip to content

Random fixes needed after the docs.rs deployment #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 1, 2019

Conversation

pietroalbini
Copy link
Member

These changes are already deployed to production.

After deploying the rustwide PR I noticed a few bugs in the previous PR. This PR contains the fixes to those bugs. The code is already deployed to production, but I'd still like a review before merging it to master.

r? @QuietMisdreavus

@pietroalbini
Copy link
Member Author

pietroalbini commented Sep 30, 2019

Note that to deploy after this branch is merged the BRANCH variable in the bin/update-docs.rs script needs to be tweaked.

Copy link
Member

@QuietMisdreavus QuietMisdreavus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for being on top of this! Feel free to merge it and fix the deploy script.

@pietroalbini pietroalbini merged commit 0868fa4 into master Oct 1, 2019
@pietroalbini pietroalbini deleted the post-rustwide-fixes branch October 1, 2019 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants