Don't add newlines after code snippets in headers #646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
templates/style.scss
Outdated
|
|
||
| /* Don't put a newline after code fragments in headers */ | ||
| h3 > code { | ||
| display: inline; |
There was a problem hiding this comment.
Just wondering: why inline and not inline-block?
There was a problem hiding this comment.
I had to look up the difference - inline-block prevents newlines within the code snippet, while inline would allow line wrapping? In that case we should probably do inline-block.
|
Couldn't find issues so once I have an answer to my question, all good for me! |
Also changes this to work on h4 since I noticed the same rustdoc style was there too.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the very odd behavior on https://docs.rs/crate/winapi/0.3.8
Closes #645
r? @GuillaumeGomez