Add tests for limits

[jyn514]

We had a queue backup this morning because the builder would panic whenever a crate had limits set (#648, https://docs.rs/releases/queue). This adds tests so that doesn't happen again.

r? @kvrhdn

[yvrhdn]

I should be able to look at this in the next couple of days @jyn514.

[yvrhdn]

Sorry for the really long lead time on this fairly small review... 😓

This looks good to me. The tests are easy to follow and cover the essential cases.

Just a small note would be: the display_limits test does not test all the different labels related to converting bytes into MB etc. We can improve the coverage by testing more unit values.
A simple change would be to tweak the test a bit to, for instance, pick a size of the build log in KB and the value of available RAM in GB? Alternatively, we could also write a test for scale specifically.

[jyn514]

Good idea! I added a test for scale and noticed at the same time that it always rounded down. I changed it so now it rounds to the closest integer instead. I was also considering printing a float rounded to 1 decimal place, what do you think?

[yvrhdn]

Yeah, makes sense! Having one digit after the decimal point provides a lot more precision. There is a significant difference between 1 GB and 1.5 GB. But at the same time, I find it difficult to reason about 1.2 hour. So it will be a bit of a trade off 😅

[jyn514]

Implemented fractional precision up to 1 decimal point. I also displayed it as an integer if the decimal was 0 (2.0 -> 2).

[yvrhdn]

But overall this looks neat 👍 I love Rust's format!!

[jyn514]

Rust is indeed wonderful! Thanks for the review, I think the new precision will be helpful :)