shims::fs adding more fields to FileMetadata #4444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
force-pushed
the
filemetadata_upd
branch
from
2f2e7a7 to
32c0974
Compare
devnexen
force-pushed
the
filemetadata_upd
branch
from
32c0974 to
c7b21c7
Compare
RalfJung
reviewed
Jul 5, 2025
src/shims/unix/fs.rs
Outdated
| @@ -1601,6 +1610,32 @@ impl FileMetadata { | |||
| let modified = extract_sec_and_nsec(metadata.modified())?; | |||
|
|
|||
| // FIXME: Provide more fields using platform specific methods. | |||
| interp_ok(Ok(FileMetadata { mode, size, created, accessed, modified })) | |||
|
|
|||
| #[cfg(unix)] | |||
There was a problem hiding this comment.
Please rearrange this so that not all the fields need to be repeated everywhere. You can use cfg_select! to insert let-bindings into the surrounding scope like here.
|
Thanks! I left a comment for reducing code duplication. :) @rustbot author |
|
Reminder, once the PR becomes ready for a review, use |
rustbot
added
the
S-waiting-on-author
addressing, partially at least, FIXME comment and targetting unixes, adding device, user and group ids.
devnexen
force-pushed
the
filemetadata_upd
branch
from
756e1eb to
fe41b77
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
|
Thanks! I did some more minor cleanup, that's easier than trying to explain it via comments. :) Please take a look, could be useful feedback for future PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressing, partially at least, FIXME comment and
targetting unixes, adding device, user and group ids.
Fixes #4379