Bump clang-sys to 0.17.0 #690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitzgen
approved these changes
May 8, 2017
| options.clang_args.push("-isystem".to_owned()); | ||
| options.clang_args.push(path); | ||
| if let Some(cpp_search_paths) = clang.cpp_search_paths { | ||
| for path in cpp_search_paths.into_iter() { |
There was a problem hiding this comment.
This already existed, but the into_iter isn't necessary right? It should be automatically called by a for loop, correct?
|
@bors-servo r+ Thanks @KyleMayes ! |
|
📌 Commit a33fb57 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
May 8, 2017
Bump clang-sys to 0.17.0 It turns out that some versions of Clang don't have `#include <...> search starts here:` in their output (KyleMayes/clang-sys#54). I changed the storage type of the include search paths in `clang-sys` from `Vec<PathBuf>` to `Option<Vec<PathBuf>>` to reflect the possibility that finding and parsing the include search paths might fail.
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that some versions of Clang don't have
#include <...> search starts here:in their output (KyleMayes/clang-sys#54).I changed the storage type of the include search paths in
clang-sysfromVec<PathBuf>toOption<Vec<PathBuf>>to reflect the possibility that finding and parsing the include search paths might fail.