`needless_borrow`: do not contradict `dangerous_implicit_autorefs` #14810

samueltardieu · 2025-05-15T10:50:51Z

Rust 1.88 introduces the dangerous_implicit_autorefs lint which warns about using implicit autorefs on a place obtained from a raw pointer, as this may create aliasing issues.

Prevent clippy::needless_borrow from triggering in this case, by disabling the lint when taking a reference on a raw pointer dereference. There might be a better way for doing this in the long run with a finer way of distinguish the problematic cases, but this will prevent Clippy from contradicting the compiler in the meantime.

Fixes #14743

changelog: [needless_borrow]: do not contradict the compiler's dangerous_implicit_autorefs lint even though the refererences are not mandatory

@rustbot label +beta-nominated

Summary Notes

Beta nomination for 1.88 by samueltardieu

Generated by triagebot, see help for how to add more

rustbot · 2025-05-15T10:50:57Z

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

samueltardieu · 2025-05-15T10:51:28Z

@Urgau ~~Any other cases you might be thinking about that would not be covered here?~~ After our discussion, I switched to ignoring references on dereferences of raw pointers altogether.

samueltardieu · 2025-05-15T13:07:58Z

@rustbot note Beta nomination for 1.88

The dangerous_implicit_autorefs compiler lint that we contradict has already entered beta 1.88. We should also target the same version to avoid lints going back and forth.

blyxyas

LGTM, thanks! ❤️ Just what I assume is a typo.

blyxyas · 2025-05-15T13:32:47Z

clippy_lints/src/dereference.rs

@@ -997,6 +997,15 @@ fn report<'tcx>(
            );
        },
        State::DerefedBorrow(state) => {
+            // Do not suggest removing a non-mandatory `&` in `&*rawptr` in an `unside` context,


Probably a "unsafe" typo?

Indeed, fixed!

Rust 1.88 introduces the `dangerous_implicit_autorefs` lint which warns about using implicit autorefs on a place obtained from a raw pointer, as this may create aliasing issues. Prevent `clippy::needless_borrow` from triggering in this case, by disabling the lint when taking a reference on a raw pointer dereference. There might be a better way for doing this in the long run with a finer way of distinguish the problematic cases, but this will prevent Clippy from contradicting the compiler in the meantime.

blyxyas

LGTM, thanks! ❤️

@rustbot

…ust-lang#14810) Rust 1.88 introduces the `dangerous_implicit_autorefs` lint which warns about using implicit autorefs on a place obtained from a raw pointer, as this may create aliasing issues. Prevent `clippy::needless_borrow` from triggering in this case, by disabling the lint when taking a reference on a raw pointer dereference. There might be a better way for doing this in the long run with a finer way of distinguish the problematic cases, but this will prevent Clippy from contradicting the compiler in the meantime. Fixes rust-lang/rust-clippy#14743 changelog: [`needless_borrow`]: do not contradict the compiler's `dangerous_implicit_autorefs` lint even though the refererences are not mandatory @rustbot label +beta-nominated   ### Summary Notes - [Beta nomination for 1.88](rust-lang/rust-clippy#14810 (comment)) by [samueltardieu](https://github.com/samueltardieu) Generated by triagebot, see [help](https://forge.rust-lang.org/triagebot/note.html) for how to add more

flip1995 · 2025-06-19T14:42:43Z

rust-lang/rust#142725

@rustbot

…ust-lang#14810) Rust 1.88 introduces the `dangerous_implicit_autorefs` lint which warns about using implicit autorefs on a place obtained from a raw pointer, as this may create aliasing issues. Prevent `clippy::needless_borrow` from triggering in this case, by disabling the lint when taking a reference on a raw pointer dereference. There might be a better way for doing this in the long run with a finer way of distinguish the problematic cases, but this will prevent Clippy from contradicting the compiler in the meantime. Fixes rust-lang/rust-clippy#14743 changelog: [`needless_borrow`]: do not contradict the compiler's `dangerous_implicit_autorefs` lint even though the refererences are not mandatory @rustbot label +beta-nominated   ### Summary Notes - [Beta nomination for 1.88](rust-lang/rust-clippy#14810 (comment)) by [samueltardieu](https://github.com/samueltardieu) Generated by triagebot, see [help](https://forge.rust-lang.org/triagebot/note.html) for how to add more

@rustbot

…ust-lang#14810) Rust 1.88 introduces the `dangerous_implicit_autorefs` lint which warns about using implicit autorefs on a place obtained from a raw pointer, as this may create aliasing issues. Prevent `clippy::needless_borrow` from triggering in this case, by disabling the lint when taking a reference on a raw pointer dereference. There might be a better way for doing this in the long run with a finer way of distinguish the problematic cases, but this will prevent Clippy from contradicting the compiler in the meantime. Fixes rust-lang/rust-clippy#14743 changelog: [`needless_borrow`]: do not contradict the compiler's `dangerous_implicit_autorefs` lint even though the refererences are not mandatory @rustbot label +beta-nominated   ### Summary Notes - [Beta nomination for 1.88](rust-lang/rust-clippy#14810 (comment)) by [samueltardieu](https://github.com/samueltardieu) Generated by triagebot, see [help](https://forge.rust-lang.org/triagebot/note.html) for how to add more

@rustbot

…ust-lang/rust-clippy#14810) Rust 1.88 introduces the `dangerous_implicit_autorefs` lint which warns about using implicit autorefs on a place obtained from a raw pointer, as this may create aliasing issues. Prevent `clippy::needless_borrow` from triggering in this case, by disabling the lint when taking a reference on a raw pointer dereference. There might be a better way for doing this in the long run with a finer way of distinguish the problematic cases, but this will prevent Clippy from contradicting the compiler in the meantime. Fixes rust-lang/rust-clippy#14743 changelog: [`needless_borrow`]: do not contradict the compiler's `dangerous_implicit_autorefs` lint even though the refererences are not mandatory @rustbot label +beta-nominated   - [Beta nomination for 1.88](rust-lang/rust-clippy#14810 (comment)) by [samueltardieu](https://github.com/samueltardieu) Generated by triagebot, see [help](https://forge.rust-lang.org/triagebot/note.html) for how to add more

[beta] backports - Make the assertion in `Ident::new` debug-only. #140880 - Avoid creating an empty identifer in `Symbol::to_ident_string`. #141318 - Backport rust-lang/stdarch#1818 for 1.88 #142694 - [beta] Clippy backport #142725 - ICE: - rust-lang/rust-clippy#14776 - Lint contradictions: - rust-lang/rust-clippy#14703 - rust-lang/rust-clippy#14810 - Smaller (in LoC changes) fixes: - rust-lang/rust-clippy#14733 - rust-lang/rust-clippy#14730 r? cuviper

[beta] backports - Make the assertion in `Ident::new` debug-only. #140880 - Avoid creating an empty identifer in `Symbol::to_ident_string`. #141318 - Backport rust-lang/stdarch#1818 for 1.88 #142694 - [beta] Clippy backport #142725 - ICE: - rust-lang/rust-clippy#14776 - Lint contradictions: - rust-lang/rust-clippy#14703 - rust-lang/rust-clippy#14810 - Smaller (in LoC changes) fixes: - rust-lang/rust-clippy#14733 - rust-lang/rust-clippy#14730 r? cuviper try-job: x86_64-msvc-ext2

[beta] backports - Make the assertion in `Ident::new` debug-only. #140880 - Avoid creating an empty identifer in `Symbol::to_ident_string`. #141318 - Backport rust-lang/stdarch#1818 for 1.88 #142694 - [beta] Clippy backport #142725 - ICE: - rust-lang/rust-clippy#14776 - Lint contradictions: - rust-lang/rust-clippy#14703 - rust-lang/rust-clippy#14810 - Smaller (in LoC changes) fixes: - rust-lang/rust-clippy#14733 - rust-lang/rust-clippy#14730 - [win][ci] Update LLVM toolchain used to build LLVM to 20 #140757 r? cuviper

rustbot assigned blyxyas May 15, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties beta-nominated Nominated for backporting to the compiler in the beta channel. labels May 15, 2025

samueltardieu force-pushed the issue-14743 branch 2 times, most recently from 39ee603 to 969e514 Compare May 15, 2025 12:47

blyxyas requested changes May 22, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels May 22, 2025

samueltardieu force-pushed the issue-14743 branch from 969e514 to 0a059d9 Compare May 23, 2025 09:12

samueltardieu requested a review from blyxyas May 23, 2025 09:13

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels May 23, 2025

blyxyas approved these changes May 23, 2025

View reviewed changes

blyxyas added this pull request to the merge queue May 23, 2025

Merged via the queue into rust-lang:master with commit 7ab910f May 23, 2025
11 checks passed

samueltardieu deleted the issue-14743 branch May 23, 2025 21:20

Urgau mentioned this pull request Jun 7, 2025

Feature request: Auto-create a tracking issue for accepted MCPs rust-lang/triagebot#2067

Open

flip1995 added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Jun 19, 2025

flip1995 mentioned this pull request Jun 19, 2025

[beta] Clippy backport rust-lang/rust#142725

Closed

cuviper mentioned this pull request Jun 20, 2025

[beta] backports rust-lang/rust#142791

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

`needless_borrow`: do not contradict `dangerous_implicit_autorefs` #14810

`needless_borrow`: do not contradict `dangerous_implicit_autorefs` #14810

Uh oh!

samueltardieu commented May 15, 2025 •

edited by rustbot

Loading

Uh oh!

rustbot commented May 15, 2025

Uh oh!

samueltardieu commented May 15, 2025 •

edited

Loading

Uh oh!

samueltardieu commented May 15, 2025 •

edited

Loading

Uh oh!

blyxyas left a comment

Uh oh!

blyxyas May 15, 2025

Uh oh!

samueltardieu May 23, 2025

Uh oh!

blyxyas left a comment

Uh oh!

Uh oh!

flip1995 commented Jun 19, 2025

Uh oh!

Uh oh!

needless_borrow: do not contradict dangerous_implicit_autorefs #14810

needless_borrow: do not contradict dangerous_implicit_autorefs #14810

Uh oh!

Conversation

samueltardieu commented May 15, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary Notes

Uh oh!

rustbot commented May 15, 2025

Uh oh!

samueltardieu commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

samueltardieu commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blyxyas left a comment

Choose a reason for hiding this comment

Uh oh!

blyxyas May 15, 2025

Choose a reason for hiding this comment

Uh oh!

samueltardieu May 23, 2025

Choose a reason for hiding this comment

Uh oh!

blyxyas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

flip1995 commented Jun 19, 2025

Uh oh!

Uh oh!

`needless_borrow`: do not contradict `dangerous_implicit_autorefs` #14810

`needless_borrow`: do not contradict `dangerous_implicit_autorefs` #14810

samueltardieu commented May 15, 2025 •

edited by rustbot

Loading

samueltardieu commented May 15, 2025 •

edited

Loading

samueltardieu commented May 15, 2025 •

edited

Loading